From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751113AbdAPStO (ORCPT ); Mon, 16 Jan 2017 13:49:14 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46334 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdAPStM (ORCPT ); Mon, 16 Jan 2017 13:49:12 -0500 Date: Mon, 16 Jan 2017 13:49:10 -0500 (EST) Message-Id: <20170116.134910.2033399594368664910.davem@davemloft.net> To: colin.king@canonical.com Cc: aduyck@mirantis.com, jiri@mellanox.com, tom@herbertland.com, edumazet@google.com, hadarh@mellanox.com, simon.horman@netronome.com, fgao@48lvckh6395k16k5.yundunddos.com, amir@vadai.me, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp From: David Miller In-Reply-To: <20170113184820.823-1-colin.king@canonical.com> References: <20170113184820.823-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Jan 2017 09:50:05 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Fri, 13 Jan 2017 18:48:20 +0000 > From: Colin Ian King > > arp is being checked instead of arp_eth to see if the call to > __skb_header_pointer failed. Fix this by checking arp_eth is > null instead of arp. Also fix to use length hlen rather than > hlen - sizeof(_arp); thanks to Eric Dumazet for spotting > this latter issue. > > CoverityScan CID#1396428 ("Logically dead code") on 2nd > arp comparison (which should be arp_eth instead). > > Fixes: commit 55733350e5e8b70c5 ("flow disector: ARP support") > Signed-off-by: Colin Ian King Applied, thanks.