From: David Miller <davem@davemloft.net>
To: dave.kleikamp@oracle.com
Cc: viro@zeniv.linux.org.uk, sparclinux@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] coredump: Ensure proper size of sparse core files
Date: Mon, 16 Jan 2017 22:42:43 -0500 (EST) [thread overview]
Message-ID: <20170116.224243.706466650029722351.davem@davemloft.net> (raw)
In-Reply-To: <32910821-8b16-1107-20de-b34d029b3e9a@oracle.com>
From: Dave Kleikamp <dave.kleikamp@oracle.com>
Date: Wed, 11 Jan 2017 13:25:00 -0600
> If the last section of a core file ends with an unmapped or zero page,
> the size of the file does not correspond with the last dump_skip() call.
> gdb complains that the file is truncated and can be confusing to users.
>
> After all of the vma sections are written, make sure that the file size
> is no smaller than the current file position.
>
> This problem can be demonstrated with gdb's bigcore testcase on the
> sparc architecture.
>
> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
The lseek() done by dump_skip() should extend the file properly.
Otherwise, everyone would be seeing this problem.
That test case passed all the time when I was last running the GDB
testsuite all the time on sparc64, say 5 years ago.
next prev parent reply other threads:[~2017-01-17 3:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 18:11 [PATCH] coredump: Ensure proper size of sparse core files Dave Kleikamp
2017-01-11 19:25 ` [PATCH RESEND] " Dave Kleikamp
2017-01-17 3:42 ` David Miller [this message]
2017-01-17 7:55 ` Christoph Hellwig
2017-01-17 20:44 ` David Miller
2017-01-17 21:01 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116.224243.706466650029722351.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave.kleikamp@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).