From: David Miller <davem@davemloft.net>
To: khalid.aziz@oracle.com
Cc: chris.hyser@oracle.com, sowmini.varadhan@oracle.com,
tushar.n.dave@oracle.com, akpm@linux-foundation.org,
nitin.m.gupta@oracle.com, gerald.schaefer@de.ibm.com,
hughd@google.com, kirill.shutemov@linux.intel.com,
adam.buchbinder@gmail.com, minchan@kernel.org,
allen.pais@oracle.com, viro@zeniv.linux.org.uk,
aryabinin@virtuozzo.com, paul.gortmaker@windriver.com,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
khalid@gonehiking.org
Subject: Re: [PATCH v4 3/4] sparc64: Add support for ADI register fields, ASIs and traps
Date: Mon, 16 Jan 2017 23:23:59 -0500 (EST) [thread overview]
Message-ID: <20170116.232359.2135717859694837287.davem@davemloft.net> (raw)
In-Reply-To: <cdd798bcaff601b83855525989e30f5c5017d32f.1483999591.git.khalid.aziz@oracle.com>
From: Khalid Aziz <khalid.aziz@oracle.com>
Date: Wed, 11 Jan 2017 09:12:53 -0700
> +#define SUN4V_MCD_PRECISE \
> + ldxa [%g0] ASI_SCRATCHPAD, %g2; \
> + ldx [%g2 + HV_FAULT_D_ADDR_OFFSET], %g4; \
> + ldx [%g2 + HV_FAULT_D_CTX_OFFSET], %g5; \
> + ba,pt %xcc, etrap; \
> + rd %pc, %g7; \
> + ba,pt %xcc, sun4v_mcd_detect_precise; \
> + nop; \
> + nop;
Always indent instructions which sit in the delay slot of a non-annulled
branch, call, or jmpl by one extra space. For example:
ba,pt %xcc, 1f
nop
> +sun4v_mcd_detect_precise:
> + or %l4, %g0, %o1
> + or %l5, %g0, %o2
> + call sun4v_mem_corrupt_detect_precise
> + add %sp, PTREGS_OFF, %o0
Likewise.
Also, just do a normal "mov x, y" instead of the "or x, %g0, y" thing.
next prev parent reply other threads:[~2017-01-17 4:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 16:12 [PATCH v4 0/4] Application Data Integrity feature introduced by SPARC M7 Khalid Aziz
2017-01-11 16:12 ` [PATCH v4 1/4] signals, sparc: Add signal codes for ADI violations Khalid Aziz
2017-01-11 16:12 ` [PATCH v4 2/4] mm: Add function to support extra actions on swap in/out Khalid Aziz
2017-01-11 16:56 ` Dave Hansen
2017-01-11 17:15 ` Khalid Aziz
2017-01-11 16:12 ` [PATCH v4 3/4] sparc64: Add support for ADI register fields, ASIs and traps Khalid Aziz
2017-01-17 4:23 ` David Miller [this message]
2017-01-17 15:55 ` Khalid Aziz
2017-01-11 16:12 ` [PATCH v4 4/4] sparc64: Add support for ADI (Application Data Integrity) Khalid Aziz
2017-01-17 4:39 ` David Miller
2017-01-17 19:32 ` Khalid Aziz
2017-01-17 19:42 ` David Miller
2017-01-17 20:12 ` Khalid Aziz
2017-01-18 0:14 ` Khalid Aziz
2017-01-11 16:33 ` [PATCH v4 0/4] Application Data Integrity feature introduced by SPARC M7 Dave Hansen
2017-01-11 16:56 ` Khalid Aziz
2017-01-11 18:13 ` Dave Hansen
2017-01-11 18:50 ` Khalid Aziz
2017-01-11 19:11 ` Dave Hansen
2017-01-12 0:22 ` Khalid Aziz
2017-01-12 0:49 ` Dave Hansen
2017-01-12 16:50 ` Khalid Aziz
2017-01-12 17:53 ` Dave Hansen
2017-01-13 0:22 ` Khalid Aziz
2017-01-13 1:31 ` Rob Gardner
2017-01-13 14:48 ` Khalid Aziz
2017-01-13 15:29 ` Rob Gardner
2017-01-13 15:59 ` Khalid Aziz
2017-01-13 16:08 ` Dave Hansen
2017-01-13 17:36 ` Rob Gardner
2017-01-17 4:47 ` David Miller
2017-01-17 21:43 ` Khalid Aziz
2017-01-17 4:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116.232359.2135717859694837287.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adam.buchbinder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=allen.pais@oracle.com \
--cc=aryabinin@virtuozzo.com \
--cc=chris.hyser@oracle.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=hughd@google.com \
--cc=khalid.aziz@oracle.com \
--cc=khalid@gonehiking.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=nitin.m.gupta@oracle.com \
--cc=paul.gortmaker@windriver.com \
--cc=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=tushar.n.dave@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).