From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442AbdAPBco (ORCPT ); Sun, 15 Jan 2017 20:32:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:44489 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173AbdAPBcn (ORCPT ); Sun, 15 Jan 2017 20:32:43 -0500 Date: Sun, 15 Jan 2017 17:32:32 -0800 From: Davidlohr Bueso To: mingo@kernel.org, peterz@infradead.org, oleg@redhat.com Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH 1/2] sched: Introduce rcuwait machinery Message-ID: <20170116013232.GA7295@linux-80c1.suse> References: <1482426096-12792-1-git-send-email-dave@stgolabs.net> <1482426096-12792-2-git-send-email-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1482426096-12792-2-git-send-email-dave@stgolabs.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Dec 2016, Bueso wrote: >+ WARN_ON(current->exit_state); \ While not related to this patch, but per 3245d6acab9 (exit: fix race between wait_consider_task() and wait_task_zombie()), should we not *_ONCE() all things ->exit_state? I'm not really refering to a specific bug (much less here, where that race would not matter obviously), but if nothing else, for documentation -- and I doubt it would make any difference performance wise. Thanks, Davidlohr