From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751074AbdAPJE6 (ORCPT ); Mon, 16 Jan 2017 04:04:58 -0500 Received: from mail.kernel.org ([198.145.29.136]:50794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbdAPJEz (ORCPT ); Mon, 16 Jan 2017 04:04:55 -0500 Date: Mon, 16 Jan 2017 17:04:39 +0800 From: Shawn Guo To: Baoyou Xie Cc: jun.nie@linaro.org, wim@iguana.be, linux@roeck-us.net, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, chen.chaokai@zte.com.cn, wang.qiang01@zte.com.cn Subject: Re: [PATCH v1 1/3] dt: bindings: add documentation for zx2967 family watchdog controller Message-ID: <20170116090438.GC11600@x250> References: <1484540395-3335-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484540395-3335-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 12:19:53PM +0800, Baoyou Xie wrote: > This patch adds dt-binding documentation for zx2967 family > watchdog controller. > > Signed-off-by: Baoyou Xie > --- > .../bindings/watchdog/zte,zx2967-wdt.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/zte,zx2967-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/zte,zx2967-wdt.txt b/Documentation/devicetree/bindings/watchdog/zte,zx2967-wdt.txt > new file mode 100644 > index 0000000..0fe0d40 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/zte,zx2967-wdt.txt > @@ -0,0 +1,29 @@ > +ZTE zx2967 Watchdog timer > + > +Required properties: > + > +- compatible : should be one of the following. > + * zte,zx296718-wdt > +- reg : Specifies base physical address and size of the registers. > +- clocks : Pairs of phandle and specifier referencing the controller's clocks. > +- clock-names: "wdtclk" for the watchdog clock. clock-names only makes sense when there are multiple clock phandles in 'clocks' property. When clock-names is not present, the driver code calls devm_clk_get() with the second parameter being NULL. > +- resets : Reference to the reset controller controlling the watchdog > + controller. > +- reset-names : Must include the following entries: > + * wdtrst Same as clock-names. > + > +Optional properties: > + > +- reset-mask-config : Mask and configuare value that be wrote to aon-sysctrl. First of all, for vendor specific properties, we should have a vendor prefix, something like "zte,reset-mask-config". Secondly, we should really have more comments to explain why this property is optional, i.e. in which cases it should be present, and in which cases it can be missing. Also, the relationship between this reset and 'resets = <&toprst 35>' should be explained a bit as well. Shawn > + > +Example: > + > +wdt_ares: watchdog@1465000 { > + compatible = "zte,zx296718-wdt"; > + reg = <0x1465000 0x1000>; > + clocks = <&topcrm WDT_WCLK>; > + clock-names = "wdtclk"; > + resets = <&toprst 35>; > + reset-names = "wdtrst"; > + reset-mask-config = <1 0x115>; > +}; > -- > 2.7.4 >