From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: peppe.cavallaro@st.com, Joao.Pinto@synopsys.com,
alexandre.torgue@st.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] stmmac: indent an if statement
Date: Mon, 16 Jan 2017 12:19:24 +0300 [thread overview]
Message-ID: <20170116091924.GA4104@mwanda> (raw)
In-Reply-To: <20170115.221438.1956356112755181222.davem@davemloft.net>
On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Thu, 12 Jan 2017 21:46:32 +0300
>
> > The break statement should be indented one more tab.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied, but like Julia I think we might have a missing of_node_put()
> here.
Of course, sorry for dropping the ball on this. I'll send a patch for
that.
regards,
dan carpenter
next prev parent reply other threads:[~2017-01-16 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 18:46 [patch net-next] stmmac: indent an if statement Dan Carpenter
2017-01-12 19:46 ` Julia Lawall
2017-01-16 3:14 ` David Miller
2017-01-16 9:19 ` Dan Carpenter [this message]
2017-01-16 9:39 ` Dan Carpenter
2017-01-16 21:46 ` Julia Lawall
2017-01-16 21:56 ` Dan Carpenter
2017-01-16 22:00 ` David Miller
2017-01-17 8:28 ` Alexandre Torgue
2017-01-16 22:10 ` Julia Lawall
2017-01-17 8:25 ` Alexandre Torgue
2017-01-17 11:45 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116091924.GA4104@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).