From: Greg KH <gregkh@linuxfoundation.org>
To: Derek Robson <robsonde@gmail.com>
Cc: mchehab@kernel.org, jb@abbadie.fr, hans.verkuil@cisco.com,
bhumirks@gmail.com, aquannie@gmail.com, claudiu.beznea@gmail.com,
bankarsandhya512@gmail.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Staging: media: bcm2048: style fix - bare use of unsigned
Date: Mon, 16 Jan 2017 11:38:04 +0100 [thread overview]
Message-ID: <20170116103804.GB2037@kroah.com> (raw)
In-Reply-To: <20170116070951.17988-1-robsonde@gmail.com>
On Mon, Jan 16, 2017 at 08:09:51PM +1300, Derek Robson wrote:
> Changed macro to not pass signedness and size as seprate fields.
> This is to improve code readablity.
Not really, it reads just fine as is. In fact, it forces you to think
about the signed vs. unsigned of the variable and doesn't let you forget
it, which seems to be the intention of the code as-is.
So I would recommend just leaving it alone.
Remember, checkpatch is a hint, you always have to use your brain when
making kernel changes, and always test-build them :)
thanks,
greg k-h
prev parent reply other threads:[~2017-01-16 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 7:09 [PATCH V2] Staging: media: bcm2048: style fix - bare use of unsigned Derek Robson
2017-01-16 10:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116103804.GB2037@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aquannie@gmail.com \
--cc=bankarsandhya512@gmail.com \
--cc=bhumirks@gmail.com \
--cc=claudiu.beznea@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=hans.verkuil@cisco.com \
--cc=jb@abbadie.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robsonde@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).