From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750884AbdAPRVn (ORCPT ); Mon, 16 Jan 2017 12:21:43 -0500 Received: from merlin.infradead.org ([205.233.59.134]:40584 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbdAPRVl (ORCPT ); Mon, 16 Jan 2017 12:21:41 -0500 Date: Mon, 16 Jan 2017 18:21:29 +0100 From: Peter Zijlstra To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err Message-ID: <20170116172129.GD6500@twins.programming.kicks-ass.net> References: <20170114091255.GA20854@linux.vnet.ibm.com> <1484385201-22227-2-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484385201-22227-2-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 14, 2017 at 01:13:03AM -0800, Paul E. McKenney wrote: > This commit switches RCU suspicious-access splats use pr_err() > instead of the current INFO printk()s. This change makes it easier > to automatically classify splats. > > Reported-by: Dmitry Vyukov > Signed-off-by: Paul E. McKenney > --- > kernel/locking/lockdep.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index 7c38f8f3d97b..844cd04bb453 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s) > #endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */ > /* Note: the following can be executed concurrently, so be careful. */ > printk("\n"); > - printk("===============================\n"); > - printk("[ INFO: suspicious RCU usage. ]\n"); > + pr_err("===============================\n"); > + pr_err("suspicious RCU usage. ]\n"); > print_kernel_ident(); > - printk("-------------------------------\n"); > - printk("%s:%d %s!\n", file, line, s); > - printk("\nother info that might help us debug this:\n\n"); > - printk("\n%srcu_scheduler_active = %d, debug_locks = %d\n", > + pr_err("-------------------------------\n"); > + pr_err("%s:%d %s!\n", file, line, s); > + pr_err("\nother info that might help us debug this:\n\n"); > + pr_err("\n%srcu_scheduler_active = %d, debug_locks = %d\n", > !rcu_lockdep_current_cpu_online() > ? "RCU used illegally from offline CPU!\n" > : !rcu_is_watching() This makes it inconsistent with the rest of lockdep; why are these more important?