linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	stefanha@redhat.com, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] virtio_scsi: Implement fc_host
Date: Tue, 17 Jan 2017 01:26:56 +0800	[thread overview]
Message-ID: <20170116172656.GB11780@lemon> (raw)
In-Reply-To: <95f96b48-aa75-0094-a634-db9c13035336@redhat.com>

On Mon, 01/16 17:45, Paolo Bonzini wrote:
> 
> 
> On 16/01/2017 17:04, Fam Zheng wrote:
> > +		node_name = virtio_cread64(vdev,
> > +			offsetof(struct virtio_scsi_config, primary_wwnn));
> > +		port_name = virtio_cread64(vdev,
> > +			offsetof(struct virtio_scsi_config, primary_wwpn));
> > +	} else {
> > +		node_name = virtio_cread64(vdev,
> > +			offsetof(struct virtio_scsi_config, secondary_wwnn));
> > +		port_name = virtio_cread64(vdev,
> > +			offsetof(struct virtio_scsi_config, secondary_wwpn));
> 
> Is the endianness correct for big-endian host here?

I think so. The fc_host sysfs uses u64 to represent port_name and node_name,
this patch does the same, so using virtio_* helpers for these fields should
handle the endianness correctly.

Maybe we should use u64 in struct virtio_scsi_config as well?

Fam

  reply	other threads:[~2017-01-16 17:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 16:04 [PATCH 0/2] virtio-scsi: Implement FC_HOST feature Fam Zheng
2017-01-16 16:04 ` [PATCH 1/2] virtio_scsi: Add fc_host definitions Fam Zheng
2017-01-16 16:04 ` [PATCH 2/2] virtio_scsi: Implement fc_host Fam Zheng
2017-01-16 16:45   ` Paolo Bonzini
2017-01-16 17:26     ` Fam Zheng [this message]
2017-01-17 13:17       ` Paolo Bonzini
2017-01-17 14:05         ` Fam Zheng
2017-01-17 15:47           ` Michael S. Tsirkin
2017-01-16 19:02   ` kbuild test robot
2017-01-17  3:40     ` Fam Zheng
2017-01-16 20:24   ` kbuild test robot
2017-01-16 17:34 ` [PATCH 0/2] virtio-scsi: Implement FC_HOST feature Christoph Hellwig
2017-01-17  3:37   ` Fam Zheng
2017-01-16 17:44 ` Hannes Reinecke
2017-01-16 20:17   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116172656.GB11780@lemon \
    --to=famz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).