From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751186AbdAQL2w (ORCPT ); Tue, 17 Jan 2017 06:28:52 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33195 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbdAQL2u (ORCPT ); Tue, 17 Jan 2017 06:28:50 -0500 Date: Tue, 17 Jan 2017 12:28:17 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Pavel Machek Cc: Jacek Anaszewski , =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , Richard Purdie , Darren Hart , Jaroslav Kysela , Takashi Iwai , Andy Shevchenko , Anthony Wong , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Message-ID: <20170117112817.GD32502@pali> References: <20170116132204.6421-1-kernel@kempniu.pl> <20170116132204.6421-7-kernel@kempniu.pl> <20170117110809.GC26116@xo-6d-61-c0.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170117110809.GC26116@xo-6d-61-c0.localdomain> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 17 January 2017 12:08:09 Pavel Machek wrote: > Hi! > > > Thanks for the patch set. > > > > Would you mind fixing also the following issues raised by > > checkpatch.pl?: > > > > WARNING: Missing a blank line after declarations > > #376: FILE: drivers/platform/x86/dell-wmi-led.c:64: > > + struct bios_args args; > ... > > The fixes could be placed in an incremental patch after this one. > > Anyway, move itself is ok (and the checkpatch issues are not that serious anyway.) > > Thanks, > > Acked-by: Pavel Machek Yes, this patch does not change code, just move one file to other location. You can add my Reviewed-by. -- Pali Rohár pali.rohar@gmail.com