From: Stafford Horne <shorne@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Stafford Horne <shorne@gmail.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kees Cook <keescook@chromium.org>, Jessica Yu <jeyu@redhat.com>,
Petr Mladek <pmladek@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Yang Shi <yang.shi@linaro.org>, Tejun Heo <tj@kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
Yaowei Bai <baiyaowei@cmss.chinamobile.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: [PATCH -next] init/main: Init jump_labels before they are used to build zonelists
Date: Tue, 17 Jan 2017 21:56:23 +0900 [thread overview]
Message-ID: <20170117125624.8535-1-shorne@gmail.com> (raw)
A recent change in -next introduced static_keys in init zonelists,
details are:
Author: Vlastimil Babka <vbabka@suse.cz>
Date: Thu Jan 12 12:19:03 2017 +1100
commit f5adbdff6a1c40e19 ("mm, page_alloc: convert
page_group_by_mobility_disable to static key")
This causes the following warning in openrisc as reported by Guenter,
and repoduced by me.
WARNING: CPU: 0 PID: 0 at ./include/linux/jump_label.h:198 0xc02d758c
static_key_slow_inc used before call to jump_label_init
This fixes this by initialized jump_labels even earlier, I am suprized the
issue is not showing up in other platforms yet.
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
init/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/init/main.c b/init/main.c
index 8b1adb6e..d1ca7cb 100644
--- a/init/main.c
+++ b/init/main.c
@@ -513,6 +513,7 @@ asmlinkage __visible void __init start_kernel(void)
boot_cpu_state_init();
smp_prepare_boot_cpu(); /* arch-specific boot-cpu hooks */
+ jump_label_init();
build_all_zonelists(NULL, NULL);
page_alloc_init();
@@ -526,8 +527,6 @@ asmlinkage __visible void __init start_kernel(void)
parse_args("Setting init args", after_dashes, NULL, 0, -1, -1,
NULL, set_init_arg);
- jump_label_init();
-
/*
* These use large bootmem allocations and must precede
* kmem_cache_init()
--
2.9.3
next reply other threads:[~2017-01-17 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 12:56 Stafford Horne [this message]
2017-01-17 13:07 ` [PATCH -next] init/main: Init jump_labels before they are used to build zonelists Vlastimil Babka
2017-01-17 13:44 ` Peter Zijlstra
2017-01-17 14:30 ` Stafford Horne
2017-01-17 16:11 ` Vlastimil Babka
2017-01-17 20:34 ` Andrew Morton
2017-01-17 20:49 ` Vlastimil Babka
2017-01-19 8:28 ` Vlastimil Babka
2017-01-19 9:56 ` Mel Gorman
2017-01-23 5:54 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117125624.8535-1-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=jeyu@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).