From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbdARVZw (ORCPT ); Wed, 18 Jan 2017 16:25:52 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41262 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbdARVZv (ORCPT ); Wed, 18 Jan 2017 16:25:51 -0500 Date: Wed, 18 Jan 2017 15:08:39 -0500 (EST) Message-Id: <20170118.150839.1789577551975200722.davem@davemloft.net> To: vineethp@amazon.com Cc: jgross@suse.com, boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kamatam@amazon.com, aliguori@amazon.com Subject: Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM From: David Miller In-Reply-To: <79c6ecce-bfcb-ebaa-afd2-05c1d86004d7@amazon.com> References: <1484330100-3960-1-git-send-email-vineethp@u480fcf3b67f557f68df1.ant.amazon.com> <79c6ecce-bfcb-ebaa-afd2-05c1d86004d7@amazon.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Jan 2017 11:09:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vineeth Remanan Pillai Date: Wed, 18 Jan 2017 09:02:17 -0800 > > On 01/15/2017 10:24 PM, Juergen Gross wrote: >> On 13/01/17 18:55, Remanan Pillai wrote: >>> From: Vineeth Remanan Pillai >>> >>> During an OOM scenario, request slots could not be created as skb >>> allocation fails. So the netback cannot pass in packets and netfront >>> wrongly assumes that there is no more work to be done and it disables >>> polling. This causes Rx to stall. >>> >>> The issue is with the retry logic which schedules the timer if the >>> created slots are less than NET_RX_SLOTS_MIN. The count of new request >>> slots to be pushed are calculated as a difference between new req_prod >>> and rsp_cons which could be more than the actual slots, if there are >>> unconsumed responses. >>> >>> The fix is to calculate the count of newly created slots as the >>> difference between new req_prod and old req_prod. >>> >>> Signed-off-by: Vineeth Remanan Pillai >> Reviewed-by: Juergen Gross > Thanks Juergen. > > David, > > Could you please pick up this change for net-next if there no more > concerns.. Why would I pick up "this change", if the author of the patch has stated that he will resubmit the change implemented differently based upon my feedback?