From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751350AbdARWkt (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Jan 2017 17:40:49 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:42940 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751089AbdARWkr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Jan 2017 17:40:47 -0500
Date: Wed, 18 Jan 2017 16:47:38 -0500 (EST)
Message-Id: <20170118.164738.406851995217401601.davem@davemloft.net>
To: linux@armlinux.org.uk
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
        f.fainelli@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170118.163714.6755964924380784.davem@davemloft.net>
References: <20170118001403.GJ27312@n2100.armlinux.org.uk>
        <20170118.163714.6755964924380784.davem@davemloft.net>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Jan 2017 12:48:33 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0IMexx3025815

From: David Miller <davem@davemloft.net>
Date: Wed, 18 Jan 2017 16:37:14 -0500 (EST)

> From: Russell King - ARM Linux <linux@armlinux.org.uk>
> Date: Wed, 18 Jan 2017 00:14:03 +0000
> 
>> Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
>> unnecessary dependency for quite a large amount of the kernel.  There's
>> very little which actually requires definitions from phy.h in net/dsa.h
>> - the include itself only wants the declaration of a couple of
>> structures and IFNAMSIZ.
>> 
>> Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
>> mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
>> and phy_fixed.h from net/dsa.h.
>> 
>> This patch reduces from around 800 files rebuilt to around 40 - even
>> with ccache, the time difference is noticable.
>> 
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Applied, thanks.

Acutallly, I'm reverting this, it breaks the build all over the place.

The problem is that it seems that somehow we are getting an implicit
module.h include via phy.h and this propagates all over the tree.  So
I get failures like:

net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or ¡...¢ before string constant
 MODULE_LICENSE("GPL v2");
 ...
net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function ¡xprt_rdma_bc_put¢:
net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function ¡module_put¢ [-Werror=implicit-function-declaration]
  module_put(THIS_MODULE);
  ^
net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function ¡xprt_setup_rdma_bc¢:
net/sunrpc/xprtrdma/svc_rdma_backchannel.c:348:7: error: implicit declaration of function ¡try_module_get¢ [-Werror=implicit-function-declaration]
  if (!try_module_get(THIS_MODULE))

Please resubmit this after you can successfully complete an allmodconfig build.

Thanks.