From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbdARMPL (ORCPT ); Wed, 18 Jan 2017 07:15:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdARMPJ (ORCPT ); Wed, 18 Jan 2017 07:15:09 -0500 Date: Wed, 18 Jan 2017 12:58:55 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen Subject: Re: [PATCH 04/11] perf, tools: Support per pmu json aliases Message-ID: <20170118115855.GA11946@krava> References: <20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-5-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103150833.6694-5-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 18 Jan 2017 11:58:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 07:08:26AM -0800, Andi Kleen wrote: > From: Andi Kleen > > Add support for registering json aliases per PMU. Any alias > with an unit matching the prefix is registered to the PMU. > Uncore has multiple instances of most units, so all > these aliases get registered for each individual PMU > (this is important later to run the event on every instance > of the PMU). > > To avoid printing the events multiple times in perf list > filter out duplicated events during printing. > > v2: Rely on uncore_ prefix already in unit > Signed-off-by: Andi Kleen > --- > tools/perf/util/pmu.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 8bffe99d8e3f..4bfc98953aba 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -587,14 +587,13 @@ static struct perf_pmu *pmu_lookup(const char *name) > if (pmu_format(name, &format)) > return NULL; > > - if (pmu_aliases(name, &aliases)) > + if (pmu_type(name, &type)) > return NULL; > > - pmu_add_cpu_aliases(&aliases, name); > - > - if (pmu_type(name, &type)) > + if (pmu_aliases(name, &aliases)) > return NULL; > > + pmu_add_cpu_aliases(&aliases, name); AFAICS you switched the calls.. how does it matter? jirka > pmu = zalloc(sizeof(*pmu)); > if (!pmu) > return NULL; > @@ -1192,6 +1191,9 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag, > len = j; > qsort(aliases, len, sizeof(struct sevent), cmp_sevent); > for (j = 0; j < len; j++) { > + /* Skip duplicates */ > + if (j > 0 && !strcmp(aliases[j].name, aliases[j - 1].name)) > + continue; > if (name_only) { > printf("%s ", aliases[j].name); > continue; > -- > 2.9.3 >