linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] objtool: fix iret's opcode
@ 2017-01-18 13:29 Jiri Slaby
  2017-01-18 16:17 ` Josh Poimboeuf
  2017-01-19  9:10 ` [tip:core/urgent] objtool: Fix IRET's opcode tip-bot for Jiri Slaby
  0 siblings, 2 replies; 3+ messages in thread
From: Jiri Slaby @ 2017-01-18 13:29 UTC (permalink / raw)
  To: mingo; +Cc: x86, linux-kernel, Jiri Slaby, Josh Poimboeuf

iret is 0xcf according to the Intel manual and also to objdump of my
vmlinux:
    1ea8:       48 cf                   iretq

Fix the opcode in arch_decode_instruction.

The previous value (0xc5) seems to correspond to lds.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
---
 tools/objtool/arch/x86/decode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
index 5e0dea2cdc01..039636ffb6c8 100644
--- a/tools/objtool/arch/x86/decode.c
+++ b/tools/objtool/arch/x86/decode.c
@@ -150,9 +150,9 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
 		*type = INSN_RETURN;
 		break;
 
-	case 0xc5: /* iret */
 	case 0xca: /* retf */
 	case 0xcb: /* retf */
+	case 0xcf: /* iret */
 		*type = INSN_CONTEXT_SWITCH;
 		break;
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-19 10:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-18 13:29 [PATCH] objtool: fix iret's opcode Jiri Slaby
2017-01-18 16:17 ` Josh Poimboeuf
2017-01-19  9:10 ` [tip:core/urgent] objtool: Fix IRET's opcode tip-bot for Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).