From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752997AbdARNgR (ORCPT ); Wed, 18 Jan 2017 08:36:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55384 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbdARNgQ (ORCPT ); Wed, 18 Jan 2017 08:36:16 -0500 Date: Wed, 18 Jan 2017 14:36:14 +0100 From: Miroslav Lichvar To: Paolo Bonzini Cc: Marcelo Tosatti , Radim Krcmar , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Cochran Subject: Re: [patch 3/3] PTP: add kvm PTP driver Message-ID: <20170118133614.GK14227@localhost> References: <20170116180147.GD31452@potion> <20170116193655.GA7649@amt.cnet> <20170116194715.GA8017@amt.cnet> <20170116200112.GB8739@amt.cnet> <20170117080327.GG14227@localhost> <20170117113052.GA27759@amt.cnet> <20170117153621.GE31452@potion> <20170118121738.GA14832@amt.cnet> <20170118122456.GC13762@amt.cnet> <94a761cb-8bcd-e1a6-d07e-02fedc423e33@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94a761cb-8bcd-e1a6-d07e-02fedc423e33@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 18 Jan 2017 13:36:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > On 18/01/2017 13:24, Marcelo Tosatti wrote: > >> Testcase: run a guest and a loop sending SIGUSR1 to vcpu0 (emulating > >> intense interrupts). Follows results: > >> Do you still want to drop it in favour of simplicity? > It's just that it's not obvious why you get better results with biased > host timestamps. What makes the biased host timestamp more precise? > > I'd rather use PTP_SYS_OFFSET_PRECISE instead, but unfortunately chrony > does not support it---but I would still prefer you to support > PTP_SYS_OFFSET_PRECISE as well. Interesting. I wasn't aware that there is a new ioctl for measuring the HW-sys offset. Adding support to chrony shouldn't be difficult. If I understand it correctly, PTP_SYS_OFFSET can be emulated on top of PTP_SYS_OFFSET_PRECISE simply by copying the sys_realtime and device fields to corresponding ts slots. The apparent delay will be zero, but that's ok if the conversion is really accurate. I'm not sure if trying to do that in the opposite direction is a good idea. An application using PTP_SYS_OFFSET_PRECISE may assume the conversion is accurate and not include any delay/dispersion in an estimate of the maximum error, which is needed in NTP for instance. If we know the host timestamp ts[1] is not in the middle between the guests timestamps ts[0] and ts[2], but rather closer to ts[2], why not simply shift ts[1] by (ts[2]-ts[0])/2 ? -- Miroslav Lichvar