From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbdARQZK (ORCPT ); Wed, 18 Jan 2017 11:25:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43272 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752523AbdARQZJ (ORCPT ); Wed, 18 Jan 2017 11:25:09 -0500 Date: Wed, 18 Jan 2017 17:18:10 +0100 From: Jiri Olsa To: Andi Kleen Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org Subject: Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias string Message-ID: <20170118161810.GA14550@krava> References: <20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-7-andi@firstfloor.org> <20170118121606.GC11946@krava> <20170118154509.GD5460@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170118154509.GD5460@tassilo.jf.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 18 Jan 2017 16:18:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 07:45:09AM -0800, Andi Kleen wrote: > On Wed, Jan 18, 2017 at 01:16:06PM +0100, Jiri Olsa wrote: > > On Tue, Jan 03, 2017 at 07:08:28AM -0800, Andi Kleen wrote: > > > > SNIP > > > > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > > > index 4bfc98953aba..e0c43698fd62 100644 > > > --- a/tools/perf/util/pmu.c > > > +++ b/tools/perf/util/pmu.c > > > @@ -275,6 +275,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name, > > > snprintf(alias->unit, sizeof(alias->unit), "%s", unit); > > > } > > > alias->per_pkg = perpkg && sscanf(perpkg, "%d", &num) == 1 && num == 1; > > > + alias->str = strdup(val); > > > > where's this one released? > > Aliases are never released AFAIK? ok, I misplaced that one with the one from sevent struct.. sry jirka