linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
	mingo@kernel.org
Subject: Re: [PATCH 07/11] perf, tools: Collapse identically named events in perf stat
Date: Wed, 18 Jan 2017 17:56:31 +0100	[thread overview]
Message-ID: <20170118165631.GA17613@krava> (raw)
In-Reply-To: <20170118163126.GE5460@tassilo.jf.intel.com>

On Wed, Jan 18, 2017 at 08:31:26AM -0800, Andi Kleen wrote:
> > > % perf stat  -a  -e unc_c_llc_lookup.any sleep 1
> > > 
> > >  Performance counter stats for 'system wide':
> > > 
> > >          2,685,120 Bytes unc_c_llc_lookup.any
> > > 
> > >        1.002648032 seconds time elapsed
> > 
> > 
> > if one of them is not supported, we get wrong output:
> 
> 
> I would argue the output is not incorrect, after all it is not supported
> if something is missing. 
> 
> Imagine this is run with an interval:
> 
> If we changed the number of output lines based on some dynamic scheduling
> condition this could confuse post processing scripts or users. Some output
> records would be completely different than others. So marking everything
> merged <not supported> in these cases is better and more consistent.
> 
> It is also difficult to change and should be a rare condition.

will it always show 'not supported', as I haven't found this in the
changelog I guess you did not know about this behaviour?

could you also please document it somewhere

jirka

  reply	other threads:[~2017-01-18 16:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 15:08 Support Intel uncore event lists v4 Andi Kleen
2017-01-03 15:08 ` [PATCH 01/11] perf, tools: Factor out scale conversion code Andi Kleen
2017-01-08 18:57   ` Jiri Olsa
2017-01-08 18:57   ` Jiri Olsa
2017-01-12 13:31     ` Arnaldo Carvalho de Melo
2017-01-12 18:07       ` Arnaldo Carvalho de Melo
2017-01-18  9:19   ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2017-01-03 15:08 ` [PATCH 02/11] perf, tools: Parse eventcode as number in jevents Andi Kleen
2017-01-08 18:57   ` Jiri Olsa
2017-01-10  1:10     ` Andi Kleen
2017-01-18 11:56       ` Jiri Olsa
2017-01-03 15:08 ` [PATCH 03/11] perf, tools: Add support for parsing uncore json files Andi Kleen
2017-01-08 18:58   ` Jiri Olsa
2017-01-12 13:32     ` Arnaldo Carvalho de Melo
2017-01-08 19:00   ` Jiri Olsa
2017-01-03 15:08 ` [PATCH 04/11] perf, tools: Support per pmu json aliases Andi Kleen
2017-01-18 11:58   ` Jiri Olsa
2017-01-19  0:17     ` Andi Kleen
2017-01-19 10:42       ` Jiri Olsa
2017-01-03 15:08 ` [PATCH 05/11] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2017-01-18 12:10   ` Jiri Olsa
2017-01-03 15:08 ` [PATCH 06/11] perf, tools: Add debug support for outputing alias string Andi Kleen
2017-01-18 12:16   ` Jiri Olsa
2017-01-18 15:45     ` Andi Kleen
2017-01-18 16:18       ` Jiri Olsa
2017-01-18 12:16   ` Jiri Olsa
2017-01-03 15:08 ` [PATCH 07/11] perf, tools: Collapse identically named events in perf stat Andi Kleen
2017-01-18 12:44   ` Jiri Olsa
2017-01-18 16:31     ` Andi Kleen
2017-01-18 16:56       ` Jiri Olsa [this message]
2017-01-18 17:28         ` Andi Kleen
2017-01-03 15:08 ` [PATCH 08/11] perf, tools: Expand PMU events by prefix match Andi Kleen
2017-01-03 15:08 ` [PATCH 09/11] perf, tools: Add a simple expression parser for JSON Andi Kleen
2017-01-03 15:08 ` [PATCH 10/11] perf, tools: Support MetricExpr header in JSON event list Andi Kleen
2017-01-03 15:08 ` [PATCH 11/11] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen
2017-01-10  1:33 Support Intel uncore event lists v4 Andi Kleen
2017-01-10  1:33 ` [PATCH 07/11] perf, tools: Collapse identically named events in perf stat Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118165631.GA17613@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).