linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, mark.rutland@arm.com,
	sboyd@codeaurora.org, srinivas.kandagatla@linaro.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 3/4] dt-bindings: phy: Add support for QMP phy
Date: Wed, 18 Jan 2017 10:22:23 -0800	[thread overview]
Message-ID: <20170118182223.GP10531@minitux> (raw)
In-Reply-To: <50612693-5345-55da-8207-8c5e721fb68a@codeaurora.org>

On Tue 17 Jan 22:54 PST 2017, Vivek Gautam wrote:
> On 01/16/2017 02:19 PM, Kishon Vijay Abraham I wrote:
> > On Tuesday 10 January 2017 04:21 PM, Vivek Gautam wrote:
[..]
> > > +		reset-names = "phy", "common", "cfg",
> > > +				"lane0", "lane1", "lane2";
> > Each lane has a separate clock, separate reset.. why not create sub-nodes for
> > each lane?
> 
> Yes, each lane has separate pipe clock and resets.
> I can have a binding such as written below.

+1

> Does it makes sense to pull in the tx, rx and pcs offsets as well
> to the child node, and iomap the entire address space of the phy ?
> 

Note that you don't have to follow the same structure in your device
driver as you describe your hardware in devicetree.

I would suggest that you replace the lane-offset and various lane
specific resources with subnodes, but keep the driver "as is".

Regards,
Bjorn

  reply	other threads:[~2017-01-18 18:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 10:51 [PATCH v4 0/4] phy: USB and PCIe phy drivers for Qcom chipsets Vivek Gautam
2017-01-10 10:51 ` [PATCH v4 1/4] dt-bindings: phy: Add support for QUSB2 phy Vivek Gautam
2017-01-10 10:51 ` [PATCH v4 2/4] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips Vivek Gautam
2017-01-16  8:45   ` Kishon Vijay Abraham I
2017-01-18  9:13     ` Vivek Gautam
2017-01-18 18:03       ` Bjorn Andersson
2017-01-23 10:13         ` Vivek Gautam
2017-01-24  9:19           ` Kishon Vijay Abraham I
2017-01-26 18:15             ` Bjorn Andersson
2017-01-27  6:24               ` Vivek Gautam
2017-02-22  3:59                 ` Vivek Gautam
2017-03-02 16:40                   ` Vivek Gautam
2017-03-07  9:04                     ` Kishon Vijay Abraham I
2017-03-07  9:26                       ` Vivek Gautam
2017-01-10 10:51 ` [PATCH v4 3/4] dt-bindings: phy: Add support for QMP phy Vivek Gautam
2017-01-16  8:49   ` Kishon Vijay Abraham I
2017-01-18  6:54     ` Vivek Gautam
2017-01-18 18:22       ` Bjorn Andersson [this message]
2017-01-19  0:40         ` Stephen Boyd
2017-01-19  5:12           ` Vivek Gautam
2017-01-19 21:42             ` Stephen Boyd
2017-01-23 12:22               ` Vivek Gautam
2017-01-24  9:33               ` Kishon Vijay Abraham I
2017-01-24 14:05                 ` Vivek Gautam
2017-01-24 14:15                   ` Kishon Vijay Abraham I
2017-01-24 16:40                     ` Vivek Gautam
2017-01-26 23:43                   ` Stephen Boyd
2017-01-27  5:16                     ` Vivek Gautam
2017-03-07 14:00                       ` Stephen Boyd
2017-03-08  6:45                         ` Vivek Gautam
2017-01-10 10:51 ` [PATCH v4 4/4] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Vivek Gautam
2017-01-10 23:20   ` Andy Gross
2017-01-11  3:36     ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118182223.GP10531@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).