From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752907AbdARSg5 (ORCPT ); Wed, 18 Jan 2017 13:36:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62120 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbdARSg4 (ORCPT ); Wed, 18 Jan 2017 13:36:56 -0500 Date: Wed, 18 Jan 2017 19:26:32 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML Subject: Re: [PATCH 2/2] perf diff: Fix -o/--order option behavior (again) Message-ID: <20170118182632.GC19212@krava> References: <20170118051457.30946-1-namhyung@kernel.org> <20170118051457.30946-2-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170118051457.30946-2-namhyung@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 18 Jan 2017 18:26:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 02:14:57PM +0900, Namhyung Kim wrote: > The commit 21e6d8428664 changed list_add() to > perf_hpp__register_sort_field(). However this resulted in a behavior > change since the field was added to the tail instead of the head. So > the -o option is mostly ignored due to its order in the list. > > This patch fixes it by adding perf_hpp__prepend_sort_field(). > > Fixes: 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field interface") > Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa thanks, jirka