From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kostenzer Felix <fkostenzer@live.at>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: sort: make it explicitly non-modular
Date: Wed, 18 Jan 2017 14:31:13 -0500 [thread overview]
Message-ID: <20170118193112.GE29778@windriver.com> (raw)
In-Reply-To: <CAHp75VczShaS0Gdm_hbWcgW-Vp12Z2XLSSU=bY1DWCKmMirczw@mail.gmail.com>
[Re: [PATCH] lib: sort: make it explicitly non-modular] On 18/01/2017 (Wed 20:03) Andy Shevchenko wrote:
> On Wed, Jan 18, 2017 at 6:20 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > The Makefile currently controlling compilation of this code is:
> >
> > lib/Kconfig.debug:config TEST_SORT
> > lib/Kconfig.debug: bool "Array-based sort test"
> >
> > and...
> >
> > lib/Makefile:obj-y += bcd.o div64.o sort.o [...]
> >
> > ...meaning that it currently is not being built as a module by anyone.
>
> Perhaps allow it to be a module?
If anything, I'd argue the other way and say we shouldn't be further
polluting Kconfig space with more super specific options. Instead
something more generic like CONFIG_ENABLE_BOOT_SELF_TESTS that at least
could be shared.
There is no real value in making something a module when it could just
as easily be thrown out as __init code/data.
>
> Besides that perhaps rename to something like test_sort.c ?
The sort.c was not added just for the test code ; it already existed for
the sort code itself.
Paul.
--
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2017-01-18 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 16:20 [PATCH] lib: sort: make it explicitly non-modular Paul Gortmaker
2017-01-18 18:03 ` Andy Shevchenko
2017-01-18 19:31 ` Paul Gortmaker [this message]
2017-01-18 20:31 ` Felix Kostenzer
2017-01-19 0:41 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118193112.GE29778@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=fkostenzer@live.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).