From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753627AbdASQVx (ORCPT ); Thu, 19 Jan 2017 11:21:53 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:59094 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753415AbdASQUt (ORCPT ); Thu, 19 Jan 2017 11:20:49 -0500 Date: Thu, 19 Jan 2017 11:09:46 -0500 (EST) Message-Id: <20170119.110946.2012674581809955045.davem@davemloft.net> To: wangkefeng.wang@huawei.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dingtianhong@huawei.com, weiyongjun1@huawei.com, guohanjun@huawei.com Subject: Re: [PATCH] ipv6: addrconf: Avoid addrconf_disable_change() using RCU read-side lock From: David Miller In-Reply-To: <1484814381-61150-1-git-send-email-wangkefeng.wang@huawei.com> References: <1484814381-61150-1-git-send-email-wangkefeng.wang@huawei.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Jan 2017 07:10:42 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kefeng Wang Date: Thu, 19 Jan 2017 16:26:21 +0800 > Just like commit 4acd4945cd1e ("ipv6: addrconf: Avoid calling > netdevice notifiers with RCU read-side lock"), it is unnecessary > to make addrconf_disable_change() use RCU iteration over the > netdev list, since it already holds the RTNL lock, or we may meet > Illegal context switch in RCU read-side critical section. > > Signed-off-by: Kefeng Wang Applied and queued up for -stable, thanks.