From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbdASAVT (ORCPT ); Wed, 18 Jan 2017 19:21:19 -0500 Received: from mga14.intel.com ([192.55.52.115]:46000 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbdASAVQ (ORCPT ); Wed, 18 Jan 2017 19:21:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,251,1477983600"; d="scan'208";a="215025952" Date: Wed, 18 Jan 2017 16:17:35 -0800 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org Subject: Re: [PATCH 04/11] perf, tools: Support per pmu json aliases Message-ID: <20170119001735.GH5460@tassilo.jf.intel.com> References: <20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-5-andi@firstfloor.org> <20170118115855.GA11946@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170118115855.GA11946@krava> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > index 8bffe99d8e3f..4bfc98953aba 100644 > > --- a/tools/perf/util/pmu.c > > +++ b/tools/perf/util/pmu.c > > @@ -587,14 +587,13 @@ static struct perf_pmu *pmu_lookup(const char *name) > > if (pmu_format(name, &format)) > > return NULL; > > > > - if (pmu_aliases(name, &aliases)) > > + if (pmu_type(name, &type)) > > return NULL; > > > > - pmu_add_cpu_aliases(&aliases, name); > > - > > - if (pmu_type(name, &type)) > > + if (pmu_aliases(name, &aliases)) > > return NULL; > > > > + pmu_add_cpu_aliases(&aliases, name); > > AFAICS you switched the calls.. how does it matter? It avoids lots of duplicate messages with -v (and also is more efficient) -Andi