From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753741AbdASWux (ORCPT ); Thu, 19 Jan 2017 17:50:53 -0500 Received: from gateway24.websitewelcome.com ([192.185.51.253]:40318 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbdASWuv (ORCPT ); Thu, 19 Jan 2017 17:50:51 -0500 X-Greylist: delayed 1470 seconds by postgrey-1.27 at vger.kernel.org; Thu, 19 Jan 2017 17:50:51 EST Date: Thu, 19 Jan 2017 16:25:27 -0600 Message-ID: <20170119162527.Horde.dlgCJSh_IwhaQiP0unQLR1R@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: power: supply: Compress return logic into one line. References: <20170112024557.GA23047@embeddedgus> <20170116234238.wqj4qmtm5uln2nsw@earth> In-Reply-To: <20170116234238.wqj4qmtm5uln2nsw@earth> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1cUL95-000ALx-8g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:13222 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey hello, Quoting Sebastian Reichel : > Hi, > > On Wed, Jan 11, 2017 at 08:45:57PM -0600, Gustavo A. R. Silva wrote: >> Simplify return logic to avoid unnecessary variable assignments. >> These issues were detected using Coccinelle and the following >> semantic patch: >> >> @@ >> local idexpression ret; >> expression e; >> @@ >> >> -ret = >> +return >> e; >> -return ret; >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/power/supply/pcf50633-charger.c | 13 ++++--------- >> 1 file changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/power/supply/pcf50633-charger.c >> b/drivers/power/supply/pcf50633-charger.c >> index d05597b..b3c1873 100644 >> --- a/drivers/power/supply/pcf50633-charger.c >> +++ b/drivers/power/supply/pcf50633-charger.c >> @@ -393,7 +393,6 @@ static int pcf50633_mbc_probe(struct >> platform_device *pdev) >> { >> struct power_supply_config psy_cfg = {}; >> struct pcf50633_mbc *mbc; >> - int ret; >> int i; >> u8 mbcs1; >> >> @@ -419,8 +418,7 @@ static int pcf50633_mbc_probe(struct >> platform_device *pdev) >> &psy_cfg); >> if (IS_ERR(mbc->adapter)) { >> dev_err(mbc->pcf->dev, "failed to register adapter\n"); >> - ret = PTR_ERR(mbc->adapter); >> - return ret; >> + return PTR_ERR(mbc->adapter); >> } >> >> mbc->usb = power_supply_register(&pdev->dev, &pcf50633_mbc_usb_desc, >> @@ -428,8 +426,7 @@ static int pcf50633_mbc_probe(struct >> platform_device *pdev) >> if (IS_ERR(mbc->usb)) { >> dev_err(mbc->pcf->dev, "failed to register usb\n"); >> power_supply_unregister(mbc->adapter); >> - ret = PTR_ERR(mbc->usb); >> - return ret; >> + return PTR_ERR(mbc->usb); >> } >> >> mbc->ac = power_supply_register(&pdev->dev, &pcf50633_mbc_ac_desc, >> @@ -438,12 +435,10 @@ static int pcf50633_mbc_probe(struct >> platform_device *pdev) >> dev_err(mbc->pcf->dev, "failed to register ac\n"); >> power_supply_unregister(mbc->adapter); >> power_supply_unregister(mbc->usb); >> - ret = PTR_ERR(mbc->ac); >> - return ret; >> + return PTR_ERR(mbc->ac); >> } >> >> - ret = sysfs_create_group(&pdev->dev.kobj, &mbc_attr_group); >> - if (ret) >> + if (sysfs_create_group(&pdev->dev.kobj, &mbc_attr_group)) >> dev_err(mbc->pcf->dev, "failed to create sysfs entries\n"); >> >> mbcs1 = pcf50633_reg_read(mbc->pcf, PCF50633_REG_MBCS1); > > Thanks, queued. > Awesome, thanks! -- Gustavo A. R. Silva