From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751433AbdATH43 (ORCPT ); Fri, 20 Jan 2017 02:56:29 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35478 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbdATH41 (ORCPT ); Fri, 20 Jan 2017 02:56:27 -0500 Date: Fri, 20 Jan 2017 15:52:39 +0800 From: Peter Chen To: rjw@rjwysocki.net Cc: Peter Chen , mark.rutland@arm.com, ulf.hansson@linaro.org, heiko@sntech.de, stephen.boyd@linaro.org, linux-kernel@vger.kernel.org, gary.bisson@boundarydevices.com, festevam@gmail.com, stillcompiling@gmail.com, arnd@arndb.de, dbaryshkov@gmail.com, vaibhav.hiremath@linaro.org, mka@chromium.org, stern@rowland.harvard.edu, devicetree@vger.kernel.org, mail@maciej.szmigiero.name, pawel.moll@arm.com, linux-pm@vger.kernel.org, s.hauer@pengutronix.de, troy.kisky@boundarydevices.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, hverkuil@xs4all.nl, oscar@naiandei.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, sre@kernel.org, broonie@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v11 2/8] power: add power sequence library Message-ID: <20170120075239.GC21013@b29397-desktop> References: <1483596119-27508-1-git-send-email-peter.chen@nxp.com> <1483596119-27508-3-git-send-email-peter.chen@nxp.com> <20170107085456.w5dhm7qadqa6tc7v@kozik-lap> <20170110070240.GA29454@b29397-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170110070240.GA29454@b29397-desktop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2017 at 03:02:41PM +0800, Peter Chen wrote: > On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote: > > On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote: > > > We have an well-known problem that the device needs to do some power > > > sequence before it can be recognized by related host, the typical > > > example like hard-wired mmc devices and usb devices. > > > > > > This power sequence is hard to be described at device tree and handled by > > > related host driver, so we have created a common power sequence > > > library to cover this requirement. The core code has supplied > > > some common helpers for host driver, and individual power sequence > > > libraries handle kinds of power sequence for devices. The pwrseq > > > librares always need to allocate extra instance for compatible > > > string match. > > > > > > pwrseq_generic is intended for general purpose of power sequence, which > > > handles gpios and clocks currently, and can cover other controls in > > > future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off > > > if only one power sequence is needed, else call of_pwrseq_on_list > > > /of_pwrseq_off_list instead (eg, USB hub driver). > > > > > > For new power sequence library, it can add its compatible string > > > to pwrseq_of_match_table, then the pwrseq core will match it with > > > DT's, and choose this library at runtime. > > > > > > Signed-off-by: Peter Chen > > > Tested-by: Maciej S. Szmigiero > > > Tested-by Joshua Clayton > > > Reviewed-by: Matthias Kaehlcke > > > Tested-by: Matthias Kaehlcke > > > > Acked-by: Krzysztof Kozlowski > > Tested on Odroid U3 (reset sequence for LAN9730): > > Tested-by: Krzysztof Kozlowski > > > > A nice ping... > Rafael, would you please review it? This series was discussed about half a year, and many people need it, I hope it can be in v4.11-rc1, thanks. -- Best Regards, Peter Chen