From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbdATKA4 (ORCPT ); Fri, 20 Jan 2017 05:00:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50310 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbdATKAz (ORCPT ); Fri, 20 Jan 2017 05:00:55 -0500 Date: Fri, 20 Jan 2017 11:01:07 +0100 From: Greg KH To: Kees Cook Cc: Juerg Haefliger , LKML Subject: Re: [PATCH] lkdtm: Fix Oops when unloading the module Message-ID: <20170120100107.GA18115@kroah.com> References: <20170119104013.8073-1-juerg.haefliger@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2017 at 02:03:11PM -0800, Kees Cook wrote: > On Thu, Jan 19, 2017 at 2:40 AM, Juerg Haefliger > wrote: > > No jprobe is registered when the module is loaded without specifying a > > crashpoint that uses a jprobe. At the moment, we unconditionally try to > > unregister the jprobe on module unload which results in an Oops. Add a > > check to fix this. > > > > Signed-off-by: Juerg Haefliger > > Ah-ha, nice catch, thanks! > > Acked-by: Kees Cook > > Greg, can you please add this to your tree when you get a chance? Will do, thanks. greg k-h