From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Liang Li <liang.z.li@intel.com>
Cc: kvm@vger.kernel.org, virtio-dev@lists.oasis-open.org,
qemu-devel@nongnu.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, amit.shah@redhat.com,
dave.hansen@intel.com, cornelia.huck@de.ibm.com,
pbonzini@redhat.com, mst@redhat.com, david@redhat.com,
aarcange@redhat.com, quintela@redhat.com
Subject: Re: [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process
Date: Fri, 20 Jan 2017 11:48:09 +0000 [thread overview]
Message-ID: <20170120114809.GH2658@work-vm> (raw)
In-Reply-To: <1482303148-22059-4-git-send-email-liang.z.li@intel.com>
* Liang Li (liang.z.li@intel.com) wrote:
<snip>
> +static void free_extended_page_bitmap(struct virtio_balloon *vb)
> +{
> + int i, bmap_count = vb->nr_page_bmap;
> +
> + for (i = 1; i < bmap_count; i++) {
> + kfree(vb->page_bitmap[i]);
> + vb->page_bitmap[i] = NULL;
> + vb->nr_page_bmap--;
> + }
> +}
> +
> +static void kfree_page_bitmap(struct virtio_balloon *vb)
> +{
> + int i;
> +
> + for (i = 0; i < vb->nr_page_bmap; i++)
> + kfree(vb->page_bitmap[i]);
> +}
It might be worth commenting that pair of functions to make it clear
why they are so different; I guess the kfree_page_bitmap
is used just before you free the structure above it so you
don't need to keep the count/pointers updated?
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-01-20 11:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 6:52 [PATCH v6 kernel 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Liang Li
2016-12-21 6:52 ` [PATCH v6 kernel 1/5] virtio-balloon: rework deflate to add page to a list Liang Li
2016-12-21 6:52 ` [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct Liang Li
2017-01-12 19:43 ` Michael S. Tsirkin
2017-01-13 9:24 ` [virtio-dev] " Li, Liang Z
2017-01-17 19:11 ` Michael S. Tsirkin
2017-01-18 1:55 ` Li, Liang Z
2017-01-18 15:30 ` Michael S. Tsirkin
2017-01-19 1:30 ` Li, Liang Z
2016-12-21 6:52 ` [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process Liang Li
2017-01-17 19:15 ` Michael S. Tsirkin
2017-01-18 4:56 ` Li, Liang Z
2017-01-18 15:30 ` Michael S. Tsirkin
2017-01-19 1:44 ` Li, Liang Z
2017-01-20 16:34 ` Michael S. Tsirkin
2017-01-20 11:48 ` Dr. David Alan Gilbert [this message]
2017-02-04 4:35 ` Li, Liang Z
2016-12-21 6:52 ` [PATCH v6 kernel 4/5] virtio-balloon: define flags and head for host request vq Liang Li
2016-12-21 6:52 ` [PATCH v6 kernel 5/5] virtio-balloon: tell host vm's unused page info Liang Li
2017-01-10 6:43 ` [PATCH v6 kernel 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Li, Liang Z
2017-01-18 10:09 ` David Hildenbrand
2017-01-18 13:29 ` Li, Liang Z
2017-01-18 15:38 ` Michael S. Tsirkin
2017-01-19 17:24 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120114809.GH2658@work-vm \
--to=dgilbert@redhat.com \
--cc=aarcange@redhat.com \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liang.z.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).