From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbdATNbq (ORCPT ); Fri, 20 Jan 2017 08:31:46 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60100 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbdATNbo (ORCPT ); Fri, 20 Jan 2017 08:31:44 -0500 Date: Fri, 20 Jan 2017 14:31:56 +0100 From: Greg KH To: Adam Borowski Cc: Manuel =?iso-8859-1?Q?Sch=F6lling?= , jslaby@suse.com, lkml14@scotdoyle.com, rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com, akpm@linux-foundation.org, paul.burton@imgtec.com, daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles Message-ID: <20170120133156.GA11329@kroah.com> References: <201701112105.R6Zog6jw%fengguang.wu@intel.com> <20170113200758.9880-4-manuel.schoelling@gmx.de> <20170119132352.GB29998@kroah.com> <1484842335.1250.7.camel@gmx.de> <20170119163314.GD22777@kroah.com> <20170119230412.ekq3uhdmdvdjqoed@angband.pl> <20170120131611.afzupatjx4y7vcwv@angband.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170120131611.afzupatjx4y7vcwv@angband.pl> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 02:16:11PM +0100, Adam Borowski wrote: > On Fri, Jan 20, 2017 at 12:04:12AM +0100, Adam Borowski wrote: > > On Thu, Jan 19, 2017 at 05:33:14PM +0100, Greg KH wrote: > > > On Thu, Jan 19, 2017 at 05:12:15PM +0100, Manuel Schölling wrote: > > > > On Thu, 2017-01-19 at 14:23 +0100, Greg KH wrote: > > > > > On Fri, Jan 13, 2017 at 09:07:57PM +0100, Manuel Schölling wrote: > > > > > > +   This feature might break your tool of choice to flush > > > > > > the scrollback > > > > > > +   buffer, e.g. clear(1) will work fine but Debian's > > > > > > clear_console(1) > > > > > > +   will be broken, which might cause security issues. > > > > > > +   You can use the escape sequence \e[3J instead if this > > > > > > feature is > > > > > > +   activated. > > > > > > I'd recommend that patch get to clear_console() first, having it use the > > > new escape sequence, if it isn't supported, shouldn't cause any > > > problems, right? > > > > doko: would you consider, pretty please with a cherry on top, applying the > > patch I've sent to this bug? The privacy/security issue is pretty minor and > > applies only to a tiny fraction of users, but I understand why Greg is > > reluctant. > > # Subject: Bug#845177 closed by Matthias Klose > # > # This is an automatic notification regarding your Bug report > # which was filed against the bash package: > # > # #845177: clear_console: assumes VT switch clears scrollback > # > # It has been closed by Matthias Klose . > [...] > # Changes: > # * clear_console: Securely erase the current console. Closes: #845177. This means it was accepted? Or rejected? confused, greg k-h