From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 2/3] ftrace: Expose ftrace_hash_empty and ftrace_lookup_ip
Date: Fri, 20 Jan 2017 14:54:20 -0500 [thread overview]
Message-ID: <20170120145420.5fc3018a@gandalf.local.home> (raw)
In-Reply-To: <20170120024447.26097-2-namhyung@kernel.org>
On Fri, 20 Jan 2017 11:44:46 +0900
Namhyung Kim <namhyung@kernel.org> wrote:
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -787,6 +787,20 @@ extern void __trace_graph_return(struct trace_array *tr,
> struct ftrace_graph_ret *trace,
> unsigned long flags, int pc);
>
> +struct ftrace_hash {
> + unsigned long size_bits;
> + struct hlist_head *buckets;
> + unsigned long count;
> + struct rcu_head rcu;
> +};
> +
> +struct ftrace_func_entry *
> +ftrace_lookup_ip(struct ftrace_hash *hash, unsigned long ip);
> +
> +static bool __always_inline ftrace_hash_empty(struct ftrace_hash *hash)
> +{
> + return !hash || !hash->count;
> +}
Note, I had to modify this patch and move this declaration outside of
the #ifdef CONFIG_FUNCTION_GRAPH_TRACER, as it failed to build when
function graph wasn't enabled. Function tracer uses this too.
-- Steve
>
> #ifdef CONFIG_DYNAMIC_FTRACE
> /* TODO: make this variable */
next prev parent reply other threads:[~2017-01-20 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 2:44 [PATCH 1/3] ftrace: Factor out __ftrace_hash_move() Namhyung Kim
2017-01-20 2:44 ` [PATCH 2/3] ftrace: Expose ftrace_hash_empty and ftrace_lookup_ip Namhyung Kim
2017-01-20 19:54 ` Steven Rostedt [this message]
2017-01-21 0:27 ` Namhyung Kim
2017-01-21 2:13 ` Steven Rostedt
2017-01-21 2:26 ` Namhyung Kim
2017-01-20 2:44 ` [PATCH 3/3] ftrace: Convert graph filter to use hash tables Namhyung Kim
2017-01-20 17:25 ` [PATCH 1/3] ftrace: Factor out __ftrace_hash_move() Steven Rostedt
2017-01-21 0:24 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120145420.5fc3018a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).