From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784AbdAUExp (ORCPT ); Fri, 20 Jan 2017 23:53:45 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:35889 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbdAUExo (ORCPT ); Fri, 20 Jan 2017 23:53:44 -0500 Date: Sat, 21 Jan 2017 07:51:43 +0300 From: Dan Carpenter To: Arnaldo Carvalho de Melo , Thomas Graf Cc: Alexei Starovoitov , Joe Stringer , "David S. Miller" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] samples/bpf: silence shift wrapping warning Message-ID: <20170121045143.GC15269@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.6.0 (2016-04-01) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org max_key is a value in the 0-63 range, so on 32 bit systems the shift could wrap. Signed-off-by: Dan Carpenter diff --git a/samples/bpf/lwt_len_hist_user.c b/samples/bpf/lwt_len_hist_user.c index ec8f3bb..bd06eef 100644 --- a/samples/bpf/lwt_len_hist_user.c +++ b/samples/bpf/lwt_len_hist_user.c @@ -68,7 +68,7 @@ int main(int argc, char **argv) for (i = 1; i <= max_key + 1; i++) { stars(starstr, data[i - 1], max_value, MAX_STARS); printf("%8ld -> %-8ld : %-8ld |%-*s|\n", - (1l << i) >> 1, (1l << i) - 1, data[i - 1], + (1ULL << i) >> 1, (1ULL << i) - 1, data[i - 1], MAX_STARS, starstr); }