From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750802AbdAVW7V (ORCPT ); Sun, 22 Jan 2017 17:59:21 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:32770 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdAVW7S (ORCPT ); Sun, 22 Jan 2017 17:59:18 -0500 Date: Sun, 22 Jan 2017 14:51:25 -0800 From: Alexei Starovoitov To: Dan Carpenter Cc: Arnaldo Carvalho de Melo , Thomas Graf , Alexei Starovoitov , Joe Stringer , "David S. Miller" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [patch] samples/bpf: silence shift wrapping warning Message-ID: <20170122225123.GA73160@ast-mbp.thefacebook.com> References: <20170121045143.GC15269@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170121045143.GC15269@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 21, 2017 at 07:51:43AM +0300, Dan Carpenter wrote: > max_key is a value in the 0-63 range, so on 32 bit systems the shift > could wrap. > > Signed-off-by: Dan Carpenter Looks fine. I think 'net-next' is ok. Acked-by: Alexei Starovoitov > diff --git a/samples/bpf/lwt_len_hist_user.c b/samples/bpf/lwt_len_hist_user.c > index ec8f3bb..bd06eef 100644 > --- a/samples/bpf/lwt_len_hist_user.c > +++ b/samples/bpf/lwt_len_hist_user.c > @@ -68,7 +68,7 @@ int main(int argc, char **argv) > for (i = 1; i <= max_key + 1; i++) { > stars(starstr, data[i - 1], max_value, MAX_STARS); > printf("%8ld -> %-8ld : %-8ld |%-*s|\n", > - (1l << i) >> 1, (1l << i) - 1, data[i - 1], > + (1ULL << i) >> 1, (1ULL << i) - 1, data[i - 1], > MAX_STARS, starstr); > } >