LKML Archive on lore.kernel.org
 help / color / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: mmarek@suse.com
Cc: linux-kbuild@vger.kernel.org, ming.lei@canonical.com,
	gregkh@linuxfoundation.org, teg@jklm.no,
	linux-kernel@vger.kernel.org, dwmw2@infradead.org,
	"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2] firmware/Makefile: force recompilation if makefile changes
Date: Mon, 23 Jan 2017 07:07:27 -0800
Message-ID: <20170123150727.4883-1-mcgrof@kernel.org> (raw)
In-Reply-To: <20170118173156.16060-1-mcgrof@kernel.org>

If you modify the target asm we currently do not force the
recompilation of the firmware files. The target asm is in
the firmware/Makefile, peg this file as a dependency to
require re-compilation of firmware targets when the asm
changes.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---

Michal,

I had this patch as part of my linker table series [0] but have split it
off as its a small atomic separate change and can go in separately. Greg
prefers this be reviewed by the kbuild tree so sending it your way.
This v2 has no modifications, just resending it to the kbuild tree.

[0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org

 firmware/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/firmware/Makefile b/firmware/Makefile
index e297e1b52636..fa3e81c2a97b 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW   $@
 wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \
 		include/config/ppc32.h include/config/ppc64.h \
 		include/config/superh32.h include/config/superh64.h \
-		include/config/x86_32.h include/config/x86_64.h)
+		include/config/x86_32.h include/config/x86_64.h \
+		firmware/Makefile)
 
 $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps)
 	$(call cmd,fwbin,$(patsubst %.gen.S,%,$@))
-- 
2.11.0

  parent reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 17:31 [PATCH] " Luis R. Rodriguez
2017-01-19 10:15 ` Greg KH
2017-01-23 14:59   ` Luis R. Rodriguez
2017-01-23 15:02     ` Greg KH
2017-01-23 15:04       ` Luis R. Rodriguez
2017-01-23 15:07 ` Luis R. Rodriguez [this message]
2017-02-06 22:03   ` [PATCH v2] " Luis R. Rodriguez
2017-02-14 19:34     ` Luis R. Rodriguez
2017-02-21 19:38       ` Luis R. Rodriguez
2017-03-11  5:37   ` Masahiro Yamada
2017-03-15  0:53     ` Luis R. Rodriguez
2017-03-16 17:43       ` Masahiro Yamada
2017-03-16 17:55         ` Luis R. Rodriguez
2017-03-18 13:32           ` Masahiro Yamada

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123150727.4883-1-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=mmarek@suse.com \
    --cc=teg@jklm.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox