From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751117AbdAWRRp (ORCPT ); Mon, 23 Jan 2017 12:17:45 -0500 Received: from mail.skyhub.de ([78.46.96.112]:42441 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbdAWRRl (ORCPT ); Mon, 23 Jan 2017 12:17:41 -0500 Date: Mon, 23 Jan 2017 18:17:32 +0100 From: Borislav Petkov To: Nicolas Dichtel Cc: arnd@arndb.de, mmarek@suse.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, airlied@linux.ie, davem@davemloft.net, linux@armlinux.org.uk, slash.tmp@free.fr, daniel.vetter@ffwll.ch, rmk+kernel@armlinux.org.uk, msalter@redhat.com, jengelh@inai.de, hch@infradead.org, tklauser@distanz.ch, mpe@ellerman.id.au, mingo@kernel.org, hpa@zytor.com Subject: Re: [PATCH v4 3/7] x86: put msr-index.h in uapi Message-ID: <20170123171732.i3qfbcsqzznppe5m@pd.tnic> References: <1484304406-10820-1-git-send-email-nicolas.dichtel@6wind.com> <1485183521-13002-1-git-send-email-nicolas.dichtel@6wind.com> <1485183521-13002-4-git-send-email-nicolas.dichtel@6wind.com> <20170123165245.7zy7nf3cx5o4vvh3@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 06:06:52PM +0100, Nicolas Dichtel wrote: > After digging a bit, it seems you have already tried to remove it in commit > b72e7464e4cf ("x86/uapi: Do not export as part of the user API > headers"), but because this file is still listed in the Kbuild file, it is still > exported. Oh great. :-\ > It would be great if we could find a consensus about what to do with > this file because it blocks patch #4 and the rest of the series. The reasoning in b72e7464e4cf was valid then and is valid now. This thing should not have been exported in the first place. And it's not like I didn't try then. Dammit! I know, we should not ever break userspace but if it were me, I'd remove that export and see what breaks. If at all. But let's see what the others think first. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.