From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750771AbdAXTm7 (ORCPT ); Tue, 24 Jan 2017 14:42:59 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:57138 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbdAXTm6 (ORCPT ); Tue, 24 Jan 2017 14:42:58 -0500 Date: Tue, 24 Jan 2017 14:42:27 -0500 (EST) Message-Id: <20170124.144227.2017106704873029028.davem@davemloft.net> To: mst@redhat.com Cc: linux-kernel@vger.kernel.org, jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, john.fastabend@gmail.com Subject: Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k From: David Miller In-Reply-To: <1485197869-11350-1-git-send-email-mst@redhat.com> References: <1485197869-11350-1-git-send-email-mst@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Jan 2017 10:43:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Mon, 23 Jan 2017 21:37:52 +0200 > I don't have any guests with PAGE_SIZE > 64k but the > code seems to be clearly broken in that case > as PAGE_SIZE / MERGEABLE_BUFFER_ALIGN will need > more than 8 bit and so the code in mergeable_ctx_to_buf_address > does not give us the actual true size. > > Cc: John Fastabend > Signed-off-by: Michael S. Tsirkin Applied, thanks Michael. I am really trying to be patient, but we are about to run out of time for fixing the adjust header XDP stuff. That should have been resolved in a week or two, but now we're basically a month or so later. Please come to some kind of agreement about how to implement this because we can't let v4.10 go out without this being resolved. Thank you.