From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750889AbdAXTxX (ORCPT ); Tue, 24 Jan 2017 14:53:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51148 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbdAXTxV (ORCPT ); Tue, 24 Jan 2017 14:53:21 -0500 Date: Tue, 24 Jan 2017 21:53:13 +0200 From: "Michael S. Tsirkin" To: David Miller Cc: linux-kernel@vger.kernel.org, jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, john.fastabend@gmail.com Subject: Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k Message-ID: <20170124215214-mutt-send-email-mst@kernel.org> References: <1485197869-11350-1-git-send-email-mst@redhat.com> <20170124.144227.2017106704873029028.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170124.144227.2017106704873029028.davem@davemloft.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 24 Jan 2017 19:53:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2017 at 02:42:27PM -0500, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Mon, 23 Jan 2017 21:37:52 +0200 > > > I don't have any guests with PAGE_SIZE > 64k but the > > code seems to be clearly broken in that case > > as PAGE_SIZE / MERGEABLE_BUFFER_ALIGN will need > > more than 8 bit and so the code in mergeable_ctx_to_buf_address > > does not give us the actual true size. > > > > Cc: John Fastabend > > Signed-off-by: Michael S. Tsirkin > > Applied, thanks Michael. > > I am really trying to be patient, but we are about to run out of > time for fixing the adjust header XDP stuff. > > That should have been resolved in a week or two, but now we're > basically a month or so later. > > Please come to some kind of agreement about how to implement this > because we can't let v4.10 go out without this being resolved. > > Thank you. I didn't realise. Why can't we? I thought that adjust_header is an optional feature that userspace can test for, so no rush. -- MST