From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbdAZEQ3 (ORCPT ); Wed, 25 Jan 2017 23:16:29 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55662 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbdAZEQ1 (ORCPT ); Wed, 25 Jan 2017 23:16:27 -0500 Date: Wed, 25 Jan 2017 23:16:25 -0500 (EST) Message-Id: <20170125.231625.778055316669261176.davem@davemloft.net> To: arnd@arndb.de Cc: stephen@networkplumber.org, linus.luessing@c0d3.blue, nikolay@cumulusnetworks.com, nbd@nbd.name, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] bridge: move maybe_deliver_addr() inside #ifdef From: David Miller In-Reply-To: <20170125222950.1352566-1-arnd@arndb.de> References: <20170125222950.1352566-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 25 Jan 2017 19:17:23 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 25 Jan 2017 23:29:33 +0100 > The only caller of this new function is inside of an #ifdef checking > for CONFIG_BRIDGE_IGMP_SNOOPING, so we should move the implementation > there too, in order to avoid this harmless warning: > > net/bridge/br_forward.c:177:13: error: 'maybe_deliver_addr' defined but not used [-Werror=unused-function] > > Fixes: 6db6f0eae605 ("bridge: multicast to unicast") > Signed-off-by: Arnd Bergmann Applied, thank you.