From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751510AbdAYLh1 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 06:37:27 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35336 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751332AbdAYLhX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 06:37:23 -0500
Date: Wed, 25 Jan 2017 12:37:19 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
        Ander Conselvan de Oliveira 
        <ander.conselvan.de.oliveira@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, intel-gfx@lists.freedesktop.org,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL
Message-ID: <20170125113718.GA29709@gmail.com>
References: <1485283642-14401-1-git-send-email-paulo.r.zanoni@intel.com>
 <20170125072903.GA20432@gmail.com>
 <87sho74br5.fsf@intel.com>
 <87pojb4bna.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pojb4bna.fsf@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jani Nikula <jani.nikula@linux.intel.com> wrote:

> On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> >> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >>
> >>> So don't forget to reserve its stolen memory bits.
> >>> 
> >>> Cc: Ingo Molnar <mingo@kernel.org>
> >>> Cc: H. Peter Anvin <hpa@zytor.com>
> >>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Cc: x86@kernel.org
> >>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>> ---
> >>>  arch/x86/kernel/early-quirks.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>> 
> >>> Found by code inspection. This is completely untested since I don't have
> >>> GLK hardware.
> >>> 
> >>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> >>> index 6a08e25..23c4f1c 100644
> >>> --- a/arch/x86/kernel/early-quirks.c
> >>> +++ b/arch/x86/kernel/early-quirks.c
> >>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> >>>  	INTEL_SKL_IDS(&gen9_early_ops),
> >>>  	INTEL_BXT_IDS(&gen9_early_ops),
> >>>  	INTEL_KBL_IDS(&gen9_early_ops),
> >>> +	INTEL_GLK_IDS(&gen9_early_ops),
> >>>  };
> >>
> >> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other 
> >> changes to the i915 GPU driver?
> >
> > It's in our -next. Ack for merging this through drm-intel along with the
> > deps?

Yeah, LGTM:

  Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo