From: Michal Hocko <mhocko@kernel.org>
To: ysxie@foxmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org,
minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com,
qiuxishi@huawei.com
Subject: Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page
Date: Wed, 25 Jan 2017 12:47:53 +0100 [thread overview]
Message-ID: <20170125114753.GJ32377@dhcp22.suse.cz> (raw)
In-Reply-To: <1485183010-9276-1-git-send-email-ysxie@foxmail.com>
On Mon 23-01-17 22:50:10, ysxie@foxmail.com wrote:
> From: Yisheng Xie <xieyisheng1@huawei.com>
>
> This patch is to extends soft offlining framework to support
> non-lru page, which already support migration after
> commit bda807d44454 ("mm: migrate: support non-lru movable page
> migration")
>
> When memory corrected errors occur on a non-lru movable page,
> we can choose to stop using it by migrating data onto another
> page and disable the original (maybe half-broken) one.
>
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> Suggested-by: Michal Hocko <mhocko@kernel.org>
> Suggested-by: Minchan Kim <minchan@kernel.org>
> Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
This doesn't compile with CONFIG_MIGRATION=n
mm/memory-failure.c: In function '__soft_offline_page':
mm/memory-failure.c:1656:3: error: implicit declaration of function 'isolate_movable_page' [-Werror=implicit-function-declaration]
ret = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
^
cc1: some warnings being treated as errors
I guess the following should handle the problem
---
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index ae8d475a9385..1da7a1f99fc7 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -57,6 +57,11 @@ static inline int migrate_pages(struct list_head *l, new_page_t new,
int reason)
{ return -ENOSYS; }
+static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode)
+{
+ return -EBUSY;
+}
+
static inline int migrate_prep(void) { return -ENOSYS; }
static inline int migrate_prep_local(void) { return -ENOSYS; }
At least it compiles fine now. I have to look at the patch yet.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-01-25 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 14:50 [PATCH v3] HWPOISON: soft offlining for non-lru movable page ysxie
2017-01-24 2:34 ` Minchan Kim
2017-01-25 11:47 ` Michal Hocko [this message]
2017-01-25 11:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125114753.GJ32377@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=vbabka@suse.cz \
--cc=ysxie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).