From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbdAYLwX (ORCPT ); Wed, 25 Jan 2017 06:52:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:38079 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdAYLwV (ORCPT ); Wed, 25 Jan 2017 06:52:21 -0500 Date: Wed, 25 Jan 2017 12:52:13 +0100 From: Michal Hocko To: ysxie@foxmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com Subject: Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page Message-ID: <20170125115212.GK32377@dhcp22.suse.cz> References: <1485183010-9276-1-git-send-email-ysxie@foxmail.com> <20170125114753.GJ32377@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170125114753.GJ32377@dhcp22.suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 25-01-17 12:47:53, Michal Hocko wrote: > On Mon 23-01-17 22:50:10, ysxie@foxmail.com wrote: > > From: Yisheng Xie > > > > This patch is to extends soft offlining framework to support > > non-lru page, which already support migration after > > commit bda807d44454 ("mm: migrate: support non-lru movable page > > migration") > > > > When memory corrected errors occur on a non-lru movable page, > > we can choose to stop using it by migrating data onto another > > page and disable the original (maybe half-broken) one. > > > > Signed-off-by: Yisheng Xie > > Suggested-by: Michal Hocko > > Suggested-by: Minchan Kim > > Acked-by: Naoya Horiguchi > > This doesn't compile with CONFIG_MIGRATION=n > > mm/memory-failure.c: In function '__soft_offline_page': > mm/memory-failure.c:1656:3: error: implicit declaration of function 'isolate_movable_page' [-Werror=implicit-function-declaration] > ret = !isolate_movable_page(page, ISOLATE_UNEVICTABLE); > ^ > cc1: some warnings being treated as errors OK, I have missed http://lkml.kernel.org/r/1485340563-60785-1-git-send-email-xieyisheng1@huawei.com so please scratch this one. -- Michal Hocko SUSE Labs