linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, mgorman@suse.de, hannes@cmpxchg.org,
	vdavydov.dev@gmail.com, pmladek@suse.com,
	sergey.senozhatsky.work@gmail.com, vegard.nossum@oracle.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.
Date: Wed, 25 Jan 2017 15:21:42 +0100	[thread overview]
Message-ID: <20170125142141.GT32377@dhcp22.suse.cz> (raw)
In-Reply-To: <201701252303.FCI17866.FOJFHMtSQOFVLO@I-love.SAKURA.ne.jp>

On Wed 25-01-17 23:03:43, Tetsuo Handa wrote:
> Andrew, what do you think about this version? There seems to be no objections.

Well, this is not true. My main objection still holds. I simply do not
think all the additional code is really worth it. Not enough to nack the
patch, though, of course. I am not questioning that the watchdog might
be useful for debugging. I just think that what we have currently tells
us enough to debug issues. Sure, you will tell that this is not
reliable, but I will argue that this should be fixed because that makes
sense regardless of the stall warning.
-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2017-01-25 14:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-06  7:15 [PATCH v6] mm: Add memory allocation watchdog kernel thread Tetsuo Handa
2016-12-15 10:24 ` Tetsuo Handa
2016-12-28 11:42   ` Tetsuo Handa
2017-01-25 14:03     ` Tetsuo Handa
2017-01-25 14:21       ` Michal Hocko [this message]
2017-01-25 18:11 ` Johannes Weiner
2017-01-25 18:45   ` Michal Hocko
2017-01-25 19:22     ` Johannes Weiner
2017-01-26  7:57       ` Michal Hocko
2017-01-26 10:28     ` Tetsuo Handa
2017-02-22  2:11       ` Tetsuo Handa
2017-01-25 23:44   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125142141.GT32377@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=vdavydov.dev@gmail.com \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).