From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Christoph Lameter <cl@linux.com>,
willy@infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org
Subject: Re: [PATCH RFC] mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU
Date: Wed, 25 Jan 2017 12:07:08 -0800 [thread overview]
Message-ID: <20170125200708.GG3989@linux.vnet.ibm.com> (raw)
In-Reply-To: <1485363887.5145.27.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, Jan 25, 2017 at 09:04:47AM -0800, Eric Dumazet wrote:
> On Wed, 2017-01-25 at 10:45 -0600, Christoph Lameter wrote:
> > On Sun, 22 Jan 2017, Paul E. McKenney wrote:
> >
> > > On Wed, Jan 18, 2017 at 06:00:24PM -0600, Christoph Lameter wrote:
> > > > On Wed, 18 Jan 2017, Paul E. McKenney wrote:
> > > >
> > > > > Actually, slab is using RCU to provide type safety to those slab users
> > > > > who request it.
> > > >
> > > > Typesafety is a side effect. The main idea here is that the object can
> > > > still be accessed in RCU sections after another processor frees the
> > > > object. We guarantee that the object is not freed but it may be reused
> > > > for another object within the RCU period.
> > > >
> > > > Can we have a name that expresses all of that properly?
> > >
> > > But of course!!! "Type safety". http://wiki.c2.com/?TypeSafe
> >
> > Well that does not convey the idea that RCU is involved here.
> >
> > SLAB_DESTROY_RCU_TYPESAFE
>
> Not clear why we need to change this very fine name ?
>
> SLAB_DESTROY_BY_RCU was only used by few of us, we know damn well what
> it means.
>
> Consider we wont be able to change it in various web pages / archives /
> changelogs.
The reason I proposed this change is that I ran into some people last
week who had burned some months learning that this very fine flag
provides only type safety, not identity safety.
Other proposals?
Thanx, Paul
next prev parent reply other threads:[~2017-01-25 20:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 11:07 [PATCH RFC] mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU Paul E. McKenney
2017-01-18 11:12 ` willy
2017-01-18 22:17 ` Paul E. McKenney
2017-01-19 0:00 ` Christoph Lameter
2017-01-23 0:46 ` Paul E. McKenney
2017-01-25 16:45 ` Christoph Lameter
2017-01-25 17:04 ` Eric Dumazet
2017-01-25 20:07 ` Paul E. McKenney [this message]
2017-01-25 22:46 ` Eric Dumazet
2017-01-25 23:05 ` Paul E. McKenney
2017-01-25 20:25 ` Johannes Weiner
2017-01-25 21:26 ` Vlastimil Babka
2017-01-25 22:35 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125200708.GG3989@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).