From: Mark Brown <broonie@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Furquan Shaikh <furquan@chromium.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Tony Lindgren <tony@atomide.com>, Len Brown <lenb@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Will Deacon <will.deacon@arm.com>, Rob Herring <robh@kernel.org>,
Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Aaron Durbin <adurbin@chromium.org>,
dlaurie@chromium.org
Subject: Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF
Date: Wed, 25 Jan 2017 20:39:07 +0000 [thread overview]
Message-ID: <20170125203907.df2elgy3ao2o2e3h@sirena.org.uk> (raw)
In-Reply-To: <20170125192711.GB27255@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]
On Wed, Jan 25, 2017 at 11:27:11AM -0800, Dmitry Torokhov wrote:
> For the record, the main issue for the drivers, which is being solved by
> exposing power supplies to the driver, is the following:
> 1. We suspend the device. Since there is no regulators the driver
> assumes that it will retain it's state upon resume
That's *not* a sensible thing for drivers to assume regardless of the
presence or absence of explicitly controlled regulators, that just seems
like a plain old driver bug. Even if there are regulators that doesn't
mean there isn't a suspend mode configuration that disables those
regulators.
> I would really hate to go through _every_ driver and add the following
> code to the resume path:
>
> #if IS_ENABLED(CONFIG_ACPI)
> if (acpi_device_was_powered_off_between_suspend_and_now(dev)) {
> completely_reinitialize_device(dev);
> }
> #endif
That's not an ACPI thing, unless the device thinks it's actively
providing a wakeup source then if the system suspends the driver should
not be surprised to have power pulled - that's pretty normal. If the
driver is a wakeup source then it's a bit different.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-01-25 20:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 0:06 [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF Furquan Shaikh
2017-01-25 0:06 ` [PATCH 1/7] drivers/regulator: Rename of_map_mode to map_mode in regulator desc Furquan Shaikh
2017-01-25 0:06 ` [PATCH 2/7] ACPI / property: have acpi_get_next_subnode take fwnode_handle Furquan Shaikh
2017-01-25 11:00 ` kbuild test robot
2017-01-25 0:06 ` [PATCH 3/7] device property: introduce fwnode_for_each_child() Furquan Shaikh
2017-01-25 0:06 ` [PATCH 4/7] device property: introduce fwnode_get_named_child_node() Furquan Shaikh
2017-01-25 0:06 ` [PATCH 5/7] device property: Export dev_fwnode Furquan Shaikh
2017-01-25 0:06 ` [PATCH 6/7] drivers/gpio: Add and export gpiod_lookup[_index] Furquan Shaikh
2017-01-25 11:18 ` kbuild test robot
2017-01-26 15:24 ` Linus Walleij
2017-01-25 0:06 ` [PATCH 7/7] drivers/regulator: Initialize regulator init data for ACPI regulators Furquan Shaikh
2017-01-25 12:29 ` [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF Lorenzo Pieralisi
2017-01-25 12:49 ` Mark Brown
2017-01-25 12:55 ` Rafael J. Wysocki
2017-01-25 16:56 ` Furquan Shaikh
2017-01-25 18:23 ` Mark Rutland
2017-01-25 18:29 ` Mark Brown
2017-01-25 18:34 ` Mark Rutland
2017-01-25 18:49 ` Mark Brown
2017-01-25 19:39 ` Mark Rutland
2017-01-25 18:44 ` Dmitry Torokhov
2017-01-25 19:27 ` Dmitry Torokhov
2017-01-25 20:39 ` Mark Brown [this message]
2017-01-25 21:17 ` Dmitry Torokhov
2017-01-25 21:30 ` Mark Brown
2017-01-25 22:05 ` Dmitry Torokhov
2017-01-25 22:25 ` Mark Brown
2017-01-25 21:44 ` Al Stone
2017-01-25 23:27 ` Dmitry Torokhov
2017-01-26 0:15 ` Al Stone
2017-01-26 0:33 ` Dmitry Torokhov
2017-01-26 10:35 ` Rafael J. Wysocki
2017-02-04 16:08 ` Mark Brown
2017-01-25 19:21 ` Lorenzo Pieralisi
2017-01-25 20:40 ` Mark Brown
2017-01-25 18:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125203907.df2elgy3ao2o2e3h@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=adurbin@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=furquan@chromium.org \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=sathyanarayana.nujella@intel.com \
--cc=tony@atomide.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).