From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752356AbdAYWXD (ORCPT ); Wed, 25 Jan 2017 17:23:03 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:60139 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbdAYWXB (ORCPT ); Wed, 25 Jan 2017 17:23:01 -0500 From: Arnd Bergmann To: Richard Purdie , Jacek Anaszewski , Pavel Machek Cc: Arnd Bergmann , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: ktd2692: avoid harmless maybe-uninitialized warning Date: Wed, 25 Jan 2017 23:22:36 +0100 Message-Id: <20170125222247.1210546-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:4ioNkNmRxBxh0KdaUe1/g+WfUXhdYBQuOw0uqmWHmZBOU3onU9h 1DHrQITchBvYCCY9xvhDZEJoMs3FJ2q4dhpk9pMBWVMQM5eQSmSjjSoSTLCJJ5Dpz+HOzCA NuKWSgNRDLstgzOZdaqv3QKK+kWWhjUwTPwc68Al8UnNmJefCnVzFfSZ23qW1ckIphoQ6Cn RcBux2oclyH3xrWVdSUUg== X-UI-Out-Filterresults: notjunk:1;V01:K0:3xn9oLOMTLQ=:I11GJX8sTZnm0UEFrmq+oR nuGnk7vLbTVIvD4gk3YzsI088WZU55hSFpIx73wya4AvO9UOw0zmlEvwGy9ZINARx6q81sGuS LnP8k3KeaD6DQVzmq+yh32z7wJEGW7YCjKXWdzoLycT5SS9jZV+FlAVsNuR7lnJosR7sQDGx/ BeAVKht3becIu0T/K9b63qpp3T/wwZ+6TfIHamScVYsik2oEWZ2TlkmgF9aHj6XjPkpHcjlEi PJlQuw3AJSKcAtbVWiaN45t1hDR0jVKrAKiT/Td7F22weN4UDmy/D7a5IJxEX7nDcvzmmE8CH dhJvpeGGKP3G2GSruKJ/1aZ5Jne+9u4tqRm7gv3uJZ8rjy+oSRhTGIuWLscj8+l80KSD85Rro +xK9wNuY2wa/b5OjG0wLW83z4RZdh70NgoCnWeMh16S2sNLIiKrpmaO9HemurfFmV4nvOEZWP Ts7XH24dkauFyOuEdQZWZ3flAhW1oGXp2a5dzM0RUgIhvDlsvDzSJ9WupzqmMRvfTYlYjkItE FPlpo569cqBhad1dVSn0u9viQAbuXnIuVMC3bZe3vfWqBDnQBS7qKVlFasiY5EcTYTZtHNV7b d0/jQFOYgrx4LVS1++wWJxmFyC62Es+hnWeNz71SioD7fErkw4yzHBXCEUHrnIOhB7F5mVigG us9OEdqEBRFj/tPOuJlPQl25mDpsbVO7EwmT5YD6sMI/ufqRhvrTBh/kHbIv4L9KiZxU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc gets confused about the control flow in ktd2692_parse_dt(), causing it to warn about what seems like a potential bug: drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe': drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized] The code is fine, and slightly reworking it in an equivalent way lets gcc figure that out too, which gets rid of the warning. Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put") Signed-off-by: Arnd Bergmann --- drivers/leds/leds-ktd2692.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c index bf23ba191ad0..45296aaca9da 100644 --- a/drivers/leds/leds-ktd2692.c +++ b/drivers/leds/leds-ktd2692.c @@ -270,15 +270,15 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, return -ENXIO; led->ctrl_gpio = devm_gpiod_get(dev, "ctrl", GPIOD_ASIS); - if (IS_ERR(led->ctrl_gpio)) { - ret = PTR_ERR(led->ctrl_gpio); + ret = PTR_ERR_OR_ZERO(led->ctrl_gpio); + if (ret) { dev_err(dev, "cannot get ctrl-gpios %d\n", ret); return ret; } led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); - if (IS_ERR(led->aux_gpio)) { - ret = PTR_ERR(led->aux_gpio); + ret = PTR_ERR_OR_ZERO(led->aux_gpio); + if (ret) { dev_err(dev, "cannot get aux-gpios %d\n", ret); return ret; } -- 2.9.0