From: Tony Lindgren <tony@atomide.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, Marcel Partap <mpartap@gmx.net>,
Mark Rutland <mark.rutland@arm.com>,
Michael Scott <michael.scott@linaro.org>
Subject: Re: [PATCHv4] mfd: cpcap: Add minimal support
Date: Wed, 25 Jan 2017 14:41:16 -0800 [thread overview]
Message-ID: <20170125224114.GK7403@atomide.com> (raw)
In-Reply-To: <20170124093534.GU16020@dell>
* Lee Jones <lee.jones@linaro.org> [170124 01:32]:
> On Thu, 05 Jan 2017, Tony Lindgren wrote:
> > +
> > + bit = irq % cpcap->regmap_conf->val_bits;
> > + mask = (1 << bit);
>
> Nit: BIT()
...
> > + * Copyright (C) 2016 Tony Lindgren <tony@atomide.com>
>
> Nit: 2017
...
> > +/*
> > + * Helpers for child devices to check the revision and vendor.
> > + *
> > + * REVISIT: No documentation for the bits below, please update
> > + * to use proper names for defines when available.
> > + */
>
> Yes, please do that.
>
> But you can do all of the above with subsequent patches.
OK I'll send you a BIT() follow-up patch.
> Applied, thanks.
Thanks, not seeing it in next or mfd git tree yet though, forgot
to push out?
Regards,
Tony
next prev parent reply other threads:[~2017-01-25 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 0:44 [PATCHv4] mfd: cpcap: Add minimal support Tony Lindgren
2017-01-23 16:30 ` Tony Lindgren
2017-01-24 9:35 ` Lee Jones
2017-01-25 22:41 ` Tony Lindgren [this message]
2017-01-26 11:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125224114.GK7403@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).