From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdAZB1S (ORCPT ); Wed, 25 Jan 2017 20:27:18 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:36929 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbdAZB1R (ORCPT ); Wed, 25 Jan 2017 20:27:17 -0500 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 26 Jan 2017 10:27:13 +0900 From: Minchan Kim To: Johannes Weiner Cc: Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode Message-ID: <20170126012713.GA21211@bbox> References: <20170123181641.23938-1-hannes@cmpxchg.org> <20170123181641.23938-2-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170123181641.23938-2-hannes@cmpxchg.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 01:16:37PM -0500, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order and don't match reclaim speed to writeback. > > Especially during deactivation, there is never a reason to skip dirty > pages; nothing is even trying to write them out from there. Don't mess > up the LRU order for nothing, shuffle these pages along. > > Signed-off-by: Johannes Weiner Acked-by: Minchan Kim