From: Mel Gorman <mgorman@suse.de>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode
Date: Thu, 26 Jan 2017 09:52:25 +0000 [thread overview]
Message-ID: <20170126095225.kvv546uvofie25ym@suse.de> (raw)
In-Reply-To: <20170123181641.23938-2-hannes@cmpxchg.org>
On Mon, Jan 23, 2017 at 01:16:37PM -0500, Johannes Weiner wrote:
> We have an elaborate dirty/writeback throttling mechanism inside the
> reclaim scanner, but for that to work the pages have to go through
> shrink_page_list() and get counted for what they are. Otherwise, we
> mess up the LRU order and don't match reclaim speed to writeback.
>
> Especially during deactivation, there is never a reason to skip dirty
> pages; nothing is even trying to write them out from there. Don't mess
> up the LRU order for nothing, shuffle these pages along.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2017-01-26 9:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 18:16 [PATCH 0/5] mm: vmscan: fix kswapd writeback regression Johannes Weiner
2017-01-23 18:16 ` [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode Johannes Weiner
2017-01-26 1:27 ` Minchan Kim
2017-01-26 9:52 ` Mel Gorman [this message]
2017-01-26 13:13 ` Michal Hocko
2017-01-23 18:16 ` [PATCH 2/5] mm: vmscan: kick flushers when we encounter dirty pages on the LRU Johannes Weiner
2017-01-26 1:35 ` Minchan Kim
2017-01-26 9:57 ` Mel Gorman
2017-01-26 17:47 ` Johannes Weiner
2017-01-26 18:47 ` Mel Gorman
2017-01-26 13:16 ` Michal Hocko
2017-01-23 18:16 ` [PATCH 3/5] mm: vmscan: remove old flusher wakeup from direct reclaim path Johannes Weiner
2017-01-26 1:38 ` Minchan Kim
2017-01-26 10:05 ` Mel Gorman
2017-01-26 18:50 ` Johannes Weiner
2017-01-26 20:45 ` Mel Gorman
2017-01-27 12:01 ` Michal Hocko
2017-01-27 14:27 ` Mel Gorman
2017-01-26 13:21 ` Michal Hocko
2017-01-23 18:16 ` [PATCH 4/5] mm: vmscan: only write dirty pages that the scanner has seen twice Johannes Weiner
2017-01-26 1:42 ` Minchan Kim
2017-01-26 10:08 ` Mel Gorman
2017-01-26 13:29 ` Michal Hocko
2017-01-23 18:16 ` [PATCH 5/5] mm: vmscan: move dirty pages out of the way until they're flushed Johannes Weiner
2017-01-26 1:47 ` Minchan Kim
2017-01-26 10:19 ` Mel Gorman
2017-01-26 20:07 ` Johannes Weiner
2017-01-26 20:58 ` Mel Gorman
2017-01-26 13:52 ` Michal Hocko
2017-01-26 5:44 ` [PATCH 0/5] mm: vmscan: fix kswapd writeback regression Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126095225.kvv546uvofie25ym@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).