From: Serge Semin <fancer.lancer@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()
Date: Thu, 26 Jan 2017 15:44:16 +0300 [thread overview]
Message-ID: <20170126124416.GC7785@mobilestation> (raw)
In-Reply-To: <20170126090145.GA942@mwanda>
On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with
> kfree() is a double free. In fact, we don't need to free it at all.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 25d47d09e1cb..f5f2c5a8d9b0 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
> pdev->ee_file->size = pdev->eesize;
> ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
> if (ret != 0) {
> - kfree(pdev->ee_file);
> dev_err(dev, "Failed to create EEPROM sysfs-node");
> return ret;
> }
> @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
>
> /* Remove EEPROM sysfs file */
> sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
> -
> - /* Free memory allocated for bin_attribute structure */
> - kfree(pdev->ee_file);
> }
>
> /*
Just got the same patch a day earlier, but still thanks for the pointing the issue out.
Regards,
-Sergey
prev parent reply other threads:[~2017-01-26 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:01 [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree() Dan Carpenter
2017-01-26 12:44 ` Serge Semin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126124416.GC7785@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).