From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753993AbdAZRTv (ORCPT ); Thu, 26 Jan 2017 12:19:51 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34160 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753074AbdAZRTt (ORCPT ); Thu, 26 Jan 2017 12:19:49 -0500 Date: Thu, 26 Jan 2017 18:19:44 +0100 From: Daniel Vetter To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Takashi Iwai , dri-devel@lists.freedesktop.org, Gustavo Padovan , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm: Clean up the 1366x768 fixup codes Message-ID: <20170126171944.45v24d23bo3743su@phenom.ffwll.local> Mail-Followup-To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Takashi Iwai , dri-devel@lists.freedesktop.org, Gustavo Padovan , linux-kernel@vger.kernel.org References: <20170117164329.10551-1-tiwai@suse.de> <20170120194617.GI31595@intel.com> <20170123082352.qdebvg6a2lyohub3@phenom.ffwll.local> <20170126144845.GG31595@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170126144845.GG31595@intel.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 04:48:45PM +0200, Ville Syrjälä wrote: > On Mon, Jan 23, 2017 at 09:23:52AM +0100, Daniel Vetter wrote: > > On Fri, Jan 20, 2017 at 09:46:17PM +0200, Ville Syrjälä wrote: > > > On Tue, Jan 17, 2017 at 05:43:29PM +0100, Takashi Iwai wrote: > > > > This is just a cleanup, no functional change. > > > > > > > > The fixup code for 1366x768 in drm_mode_create_from_cmdline_mode() is > > > > basically a copy of the existing code in drm_edid.c. Make the latter > > > > code public so that it can be called from the former function. > > > > > > > > Signed-off-by: Takashi Iwai > > > > --- > > > > v1->v2: Fix the wrong line removal of drm_mode_set_crtcinfo() call > > > > > > We prefer to include the changelog in the commit message proper. > > > But it can be hoisted up easily enough when pushing. > > > > > > lgtm > > > Reviewed-by: Ville Syrjälä > > > > Ville, can you pls also apply&push this to drm-misc.git? > > This would need a backmerge of the preceding fix into drm-misc-next. Ok, that should happen after -rc6 is out, we already need it for something else. I'll forget about this one here now and assume you'll handle it :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch