From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbdAZVVB (ORCPT ); Thu, 26 Jan 2017 16:21:01 -0500 Received: from mga09.intel.com ([134.134.136.24]:24393 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753516AbdAZVU6 (ORCPT ); Thu, 26 Jan 2017 16:20:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,291,1477983600"; d="scan'208";a="35989990" From: Jarkko Sakkinen To: intel-sgx-kernel-dev@ml01.01.org Cc: Jarkko Sakkinen , Darren Hart , platform-driver-x86@vger.kernel.org (open list:X86 PLATFORM DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/3] intel_sgx: do not use BUG() in sgx_free_page() Date: Thu, 26 Jan 2017 23:20:36 +0200 Message-Id: <20170126212038.12809-2-jarkko.sakkinen@linux.intel.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170126212038.12809-1-jarkko.sakkinen@linux.intel.com> References: <20170126212038.12809-1-jarkko.sakkinen@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org EREMOVE fails on non-EPC page or when a SECS page with children is to be removed. These do not happen if the driver is working correctly. Log the error but do not crash the driver. Signed-off-by: Jarkko Sakkinen --- drivers/platform/x86/intel_sgx_page_cache.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel_sgx_page_cache.c b/drivers/platform/x86/intel_sgx_page_cache.c index d073057..7f73ac7 100644 --- a/drivers/platform/x86/intel_sgx_page_cache.c +++ b/drivers/platform/x86/intel_sgx_page_cache.c @@ -551,10 +551,8 @@ void sgx_free_page(struct sgx_epc_page *entry, ret = __eremove(epc); sgx_put_epc_page(epc); - if (ret) { - pr_err("EREMOVE returned %d\n", ret); - BUG(); - } + if (ret) + sgx_err(encl, "EREMOVE returned %d\n", ret); } spin_lock(&sgx_free_list_lock); -- 2.9.3