From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbdA0PV7 (ORCPT ); Fri, 27 Jan 2017 10:21:59 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:37869 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754747AbdA0PVs (ORCPT ); Fri, 27 Jan 2017 10:21:48 -0500 From: Colin King To: "David S . Miller" , Pavel Belous , Alexander Loktionov , Dmitry Bezrukov , David VomLehn , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][net-next] net: ethernet: aquantia: remove redundant err check Date: Fri, 27 Jan 2017 14:43:46 +0000 Message-Id: <20170127144346.18565-1-colin.king@canonical.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The check on err < 0 is redundant and can be removed. Detected by CoverityScan, CID#1398321 ("Logically Dead Code") Signed-off-by: Colin Ian King --- drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c index afcecdb..da4bc09 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c @@ -145,8 +145,6 @@ int aq_pci_func_init(struct aq_pci_func_s *self) } } - if (err < 0) - goto err_exit; for (i = 0; i < self->aq_hw_caps.msix_irqs; i++) self->msix_entry[i].entry = i; -- 2.10.2